Re: [PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-22 Thread Krish Sadhukhan
On 10/20/2018 03:50 PM, KarimAllah Ahmed wrote: The spec only requires the posted interrupt descriptor address to be 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also forces the address to be page aligned. Only validate that the address does not cross the maximum physical

Re: [PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-22 Thread Krish Sadhukhan
On 10/20/2018 03:50 PM, KarimAllah Ahmed wrote: The spec only requires the posted interrupt descriptor address to be 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also forces the address to be page aligned. Only validate that the address does not cross the maximum physical

Re: [PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-22 Thread Jim Mattson
On Sat, Oct 20, 2018 at 3:50 PM, KarimAllah Ahmed wrote: > The spec only requires the posted interrupt descriptor address to be > 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also > forces the address to be page aligned. > > Only validate that the address does not cross the

Re: [PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-22 Thread Jim Mattson
On Sat, Oct 20, 2018 at 3:50 PM, KarimAllah Ahmed wrote: > The spec only requires the posted interrupt descriptor address to be > 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also > forces the address to be page aligned. > > Only validate that the address does not cross the

[PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-20 Thread KarimAllah Ahmed
The spec only requires the posted interrupt descriptor address to be 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also forces the address to be page aligned. Only validate that the address does not cross the maximum physical address without enforcing a page alignment. v1 ->

[PATCH v2] KVM/nVMX: Do not validate that posted_intr_desc_addr is page aligned

2018-10-20 Thread KarimAllah Ahmed
The spec only requires the posted interrupt descriptor address to be 64-bytes aligned (i.e. bits[0:5] == 0). Using page_address_valid also forces the address to be page aligned. Only validate that the address does not cross the maximum physical address without enforcing a page alignment. v1 ->