Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Niklas Schnelle
On 8/13/20 3:11 PM, Matthew Rosato wrote: > On 8/13/20 8:34 AM, Niklas Schnelle wrote: >> >> >> On 8/13/20 12:40 PM, Niklas Schnelle wrote: >>> >>> >>> On 8/13/20 11:59 AM, Oliver O'Halloran wrote: On Thu, Aug 13, 2020 at 7:00 PM Niklas Schnelle wrote: > > > On 8/13/20

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Matthew Rosato
On 8/13/20 8:34 AM, Niklas Schnelle wrote: On 8/13/20 12:40 PM, Niklas Schnelle wrote: On 8/13/20 11:59 AM, Oliver O'Halloran wrote: On Thu, Aug 13, 2020 at 7:00 PM Niklas Schnelle wrote: On 8/13/20 3:55 AM, Oliver O'Halloran wrote: On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Matthew Rosato
On 8/12/20 4:32 PM, Alex Williamson wrote: On Wed, 12 Aug 2020 15:21:11 -0400 Matthew Rosato wrote: s390x has the notion of providing VFs to the kernel in a manner where the associated PF is inaccessible other than via firmware. These are not treated as typical VFs and access to them is

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Niklas Schnelle
On 8/13/20 12:40 PM, Niklas Schnelle wrote: > > > On 8/13/20 11:59 AM, Oliver O'Halloran wrote: >> On Thu, Aug 13, 2020 at 7:00 PM Niklas Schnelle >> wrote: >>> >>> >>> On 8/13/20 3:55 AM, Oliver O'Halloran wrote: On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato wrote: >

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Niklas Schnelle
On 8/13/20 11:59 AM, Oliver O'Halloran wrote: > On Thu, Aug 13, 2020 at 7:00 PM Niklas Schnelle > wrote: >> >> >> On 8/13/20 3:55 AM, Oliver O'Halloran wrote: >>> On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato >>> wrote: *snip* diff --git a/arch/s390/pci/pci.c

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Oliver O'Halloran
On Thu, Aug 13, 2020 at 7:00 PM Niklas Schnelle wrote: > > > On 8/13/20 3:55 AM, Oliver O'Halloran wrote: > > On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato > > wrote: > >> *snip* > >> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c > >> index 3902c9f..04ac76d 100644 > >> ---

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Niklas Schnelle
On 8/13/20 3:55 AM, Oliver O'Halloran wrote: > On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato wrote: >> >> s390x has the notion of providing VFs to the kernel in a manner >> where the associated PF is inaccessible other than via firmware. >> These are not treated as typical VFs and access to

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Niklas Schnelle
On 8/13/20 3:59 AM, Oliver O'Halloran wrote: > On Thu, Aug 13, 2020 at 6:33 AM Alex Williamson > wrote: >> >> On Wed, 12 Aug 2020 15:21:11 -0400 >> Matthew Rosato wrote: >> ... snip ... >> >> Is there too much implicit knowledge in defining a "detached VF"? For >> example, why do we know

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Oliver O'Halloran
On Thu, Aug 13, 2020 at 6:33 AM Alex Williamson wrote: > > On Wed, 12 Aug 2020 15:21:11 -0400 > Matthew Rosato wrote: > > > @@ -521,7 +522,8 @@ static int vfio_basic_config_read(struct > > vfio_pci_device *vdev, int pos, > > count = vfio_default_config_read(vdev, pos, count, perm, offset,

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Oliver O'Halloran
On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato wrote: > > s390x has the notion of providing VFs to the kernel in a manner > where the associated PF is inaccessible other than via firmware. > These are not treated as typical VFs and access to them is emulated > by underlying firmware which can

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Alex Williamson
On Wed, 12 Aug 2020 15:21:11 -0400 Matthew Rosato wrote: > s390x has the notion of providing VFs to the kernel in a manner > where the associated PF is inaccessible other than via firmware. > These are not treated as typical VFs and access to them is emulated > by underlying firmware which can

[PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Matthew Rosato
s390x has the notion of providing VFs to the kernel in a manner where the associated PF is inaccessible other than via firmware. These are not treated as typical VFs and access to them is emulated by underlying firmware which can still access the PF. After abafbc55 however these detached VFs were