Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-15 Thread Lorenzo Pieralisi
On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > Fix child-node lookup during initialisation which was using the wrong > OF-helper and ended up searching the whole device tree depth-first > starting at the parent rather than just matching on its children. > > To make things worse, t

Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-12 Thread Johan Hovold
On Tue, Dec 12, 2017 at 06:07:31PM +, Lorenzo Pieralisi wrote: > On Tue, Dec 12, 2017 at 11:25:37AM -0600, Bjorn Helgaas wrote: > > On Mon, Dec 11, 2017 at 10:42:33AM +, Lorenzo Pieralisi wrote: > > > On Mon, Dec 11, 2017 at 11:29:55AM +0100, Johan Hovold wrote: > > > > On Fri, Nov 17, 2017

Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-12 Thread Lorenzo Pieralisi
On Tue, Dec 12, 2017 at 11:25:37AM -0600, Bjorn Helgaas wrote: > On Mon, Dec 11, 2017 at 10:42:33AM +, Lorenzo Pieralisi wrote: > > On Mon, Dec 11, 2017 at 11:29:55AM +0100, Johan Hovold wrote: > > > On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > > > > Fix child-node lookup dur

Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-12 Thread Bjorn Helgaas
On Mon, Dec 11, 2017 at 10:42:33AM +, Lorenzo Pieralisi wrote: > On Mon, Dec 11, 2017 at 11:29:55AM +0100, Johan Hovold wrote: > > On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > > > Fix child-node lookup during initialisation which was using the wrong > > > OF-helper and ended

Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-11 Thread Lorenzo Pieralisi
On Mon, Dec 11, 2017 at 11:29:55AM +0100, Johan Hovold wrote: > On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > > Fix child-node lookup during initialisation which was using the wrong > > OF-helper and ended up searching the whole device tree depth-first > > starting at the parent r

Re: [PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-12-11 Thread Johan Hovold
On Fri, Nov 17, 2017 at 02:38:31PM +0100, Johan Hovold wrote: > Fix child-node lookup during initialisation which was using the wrong > OF-helper and ended up searching the whole device tree depth-first > starting at the parent rather than just matching on its children. > > To make things worse, t

[PATCH v2] PCI: keystone: fix interrupt-controller-node lookup

2017-11-17 Thread Johan Hovold
Fix child-node lookup during initialisation which was using the wrong OF-helper and ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent pci node could end up being prematurely freed as of_find_node_