Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-23 Thread Martin K. Petersen
Artem, > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL before calling > rdac_failover_get():

Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-23 Thread Martin K. Petersen
Artem, > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL before calling > rdac_failover_get():

Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-21 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-21 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

[PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-20 Thread Artem Savkov
rdac_failover_get references struct rdac_controller as ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being inefficient this also introduces a null-pointer dereference as send_mode_select() sets ctlr->ms_sdev to NULL before calling rdac_failover_get(): [ 18.432550]

[PATCH v2] Use ctlr directly in rdac_failover_get()

2017-05-20 Thread Artem Savkov
rdac_failover_get references struct rdac_controller as ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being inefficient this also introduces a null-pointer dereference as send_mode_select() sets ctlr->ms_sdev to NULL before calling rdac_failover_get(): [ 18.432550]