Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-10 Thread Chen Gang
On 01/09/2014 02:41 PM, Vineet Gupta wrote: > Forwarding to Chen's email address: > Oh, thank you for your forwarding, sorry for I really did not notice about it. > On Monday 06 January 2014 02:56 PM, Michal Marek wrote: ... >> Oops :). I wanted to ask if this is the final patch that should be

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-10 Thread Chen Gang
On 01/09/2014 02:41 PM, Vineet Gupta wrote: Forwarding to Chen's email address: Oh, thank you for your forwarding, sorry for I really did not notice about it. On Monday 06 January 2014 02:56 PM, Michal Marek wrote: ... Oops :). I wanted to ask if this is the final patch that should be

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-08 Thread Vineet Gupta
Forwarding to Chen's email address: On Monday 06 January 2014 02:56 PM, Michal Marek wrote: > On 2014-01-06 06:36, Vineet Gupta wrote: >> Hi Michal, >> >> On Friday 03 January 2014 06:08 PM, Michal Marek wrote: >>> On 2013-11-21 10:58, Vineet Gupta wrote: On 11/01/2013 11:15 AM, Vineet Gupta

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-08 Thread Vineet Gupta
Forwarding to Chen's email address: On Monday 06 January 2014 02:56 PM, Michal Marek wrote: On 2014-01-06 06:36, Vineet Gupta wrote: Hi Michal, On Friday 03 January 2014 06:08 PM, Michal Marek wrote: On 2013-11-21 10:58, Vineet Gupta wrote: On 11/01/2013 11:15 AM, Vineet Gupta wrote: +CC

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-06 Thread Michal Marek
On 2014-01-06 06:36, Vineet Gupta wrote: > Hi Michal, > > On Friday 03 January 2014 06:08 PM, Michal Marek wrote: >> On 2013-11-21 10:58, Vineet Gupta wrote: >>> On 11/01/2013 11:15 AM, Vineet Gupta wrote: +CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-06 Thread Michal Marek
On 2014-01-06 06:36, Vineet Gupta wrote: Hi Michal, On Friday 03 January 2014 06:08 PM, Michal Marek wrote: On 2013-11-21 10:58, Vineet Gupta wrote: On 11/01/2013 11:15 AM, Vineet Gupta wrote: +CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this patch and suggest the

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-05 Thread Vineet Gupta
Hi Michal, On Friday 03 January 2014 06:08 PM, Michal Marek wrote: > On 2013-11-21 10:58, Vineet Gupta wrote: >> On 11/01/2013 11:15 AM, Vineet Gupta wrote: >>> +CC Sam, Tim, Joe, Michal, David >>> >>> Guys can you please take a look at this patch and suggest the best way to >>> merge. >>> >>>

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-05 Thread Vineet Gupta
Hi Michal, On Friday 03 January 2014 06:08 PM, Michal Marek wrote: On 2013-11-21 10:58, Vineet Gupta wrote: On 11/01/2013 11:15 AM, Vineet Gupta wrote: +CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this patch and suggest the best way to merge. The root cause is some

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-03 Thread Michal Marek
On 2013-11-21 10:58, Vineet Gupta wrote: > On 11/01/2013 11:15 AM, Vineet Gupta wrote: >> +CC Sam, Tim, Joe, Michal, David >> >> Guys can you please take a look at this patch and suggest the best way to >> merge. >> >> The root cause is some gas ports (including ARC) use ';' for comment (vs. >>

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2014-01-03 Thread Michal Marek
On 2013-11-21 10:58, Vineet Gupta wrote: On 11/01/2013 11:15 AM, Vineet Gupta wrote: +CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this patch and suggest the best way to merge. The root cause is some gas ports (including ARC) use ';' for comment (vs. newline) More

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-31 Thread Vineet Gupta
+CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this patch and suggest the best way to merge. The root cause is some gas ports (including ARC) use ';' for comment (vs. newline) More background at https://lkml.org/lkml/2013/10/24/365 On 10/29/2013 07:21 AM, Chen Gang wrote:

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-31 Thread Vineet Gupta
+CC Sam, Tim, Joe, Michal, David Guys can you please take a look at this patch and suggest the best way to merge. The root cause is some gas ports (including ARC) use ';' for comment (vs. newline) More background at https://lkml.org/lkml/2013/10/24/365 On 10/29/2013 07:21 AM, Chen Gang wrote:

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-29 Thread Chen Gang
On 10/29/2013 01:55 PM, Vineet Gupta wrote: > On 10/29/2013 07:21 AM, Chen Gang wrote: >> For some assemblers, they use another character as newline in a macro >> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a >> macro) instead of ';' for it. >> >> Also need notice about

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-29 Thread Chen Gang
On 10/29/2013 01:55 PM, Vineet Gupta wrote: On 10/29/2013 07:21 AM, Chen Gang wrote: For some assemblers, they use another character as newline in a macro (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a macro) instead of ';' for it. Also need notice about code styles

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-28 Thread Vineet Gupta
On 10/29/2013 07:21 AM, Chen Gang wrote: > For some assemblers, they use another character as newline in a macro > (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a > macro) instead of ';' for it. > > Also need notice about code styles ('\t' for each line). > > >

[PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-28 Thread Chen Gang
For some assemblers, they use another character as newline in a macro (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a macro) instead of ';' for it. Also need notice about code styles ('\t' for each line). Signed-off-by: Chen Gang --- arch/arc/include/asm/linkage.h |2

Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-28 Thread Vineet Gupta
On 10/29/2013 07:21 AM, Chen Gang wrote: For some assemblers, they use another character as newline in a macro (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a macro) instead of ';' for it. Also need notice about code styles ('\t' for each line). Signed-off-by: Chen

[PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-28 Thread Chen Gang
For some assemblers, they use another character as newline in a macro (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a macro) instead of ';' for it. Also need notice about code styles ('\t' for each line). Signed-off-by: Chen Gang gang.c...@asianux.com ---