Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 9 December 2016 at 14:52, Robert Richter wrote: > On 09.12.16 21:15:12, Yisheng Xie wrote: >> For invalid pages, their zone and node information is not initialized, and it >> do have risk to trigger the BUG_ON, so I have a silly question, >> why not just change the

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 9 December 2016 at 14:52, Robert Richter wrote: > On 09.12.16 21:15:12, Yisheng Xie wrote: >> For invalid pages, their zone and node information is not initialized, and it >> do have risk to trigger the BUG_ON, so I have a silly question, >> why not just change the BUG_ON: > > We need to get

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 09.12.16 20:14:24, Yisheng Xie wrote: > We have merged your patch to 4.9.0-rc8, however we still meet the similar > problem > on our D05 board: I assume you can reliable trigger the bug. Can you add some debug messages that show the pfn number, node id, memory range. Also, add to kernel

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 09.12.16 20:14:24, Yisheng Xie wrote: > We have merged your patch to 4.9.0-rc8, however we still meet the similar > problem > on our D05 board: I assume you can reliable trigger the bug. Can you add some debug messages that show the pfn number, node id, memory range. Also, add to kernel

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 09.12.16 21:15:12, Yisheng Xie wrote: > For invalid pages, their zone and node information is not initialized, and it > do have risk to trigger the BUG_ON, so I have a silly question, > why not just change the BUG_ON: We need to get the page handling correct. Modifying the BUG_ON() just hides

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 09.12.16 21:15:12, Yisheng Xie wrote: > For invalid pages, their zone and node information is not initialized, and it > do have risk to trigger the BUG_ON, so I have a silly question, > why not just change the BUG_ON: We need to get the page handling correct. Modifying the BUG_ON() just hides

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 2016/12/9 20:23, Hanjun Guo wrote: > On 12/09/2016 08:19 PM, Ard Biesheuvel wrote: >> On 9 December 2016 at 12:14, Yisheng Xie wrote: >>> Hi Robert, >>> We have merged your patch to 4.9.0-rc8, however we still meet the similar >>> problem >>> on our D05 board: >>> >>

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 2016/12/9 20:23, Hanjun Guo wrote: > On 12/09/2016 08:19 PM, Ard Biesheuvel wrote: >> On 9 December 2016 at 12:14, Yisheng Xie wrote: >>> Hi Robert, >>> We have merged your patch to 4.9.0-rc8, however we still meet the similar >>> problem >>> on our D05 board: >>> >> >> To be clear: does

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 12/09/2016 08:19 PM, Ard Biesheuvel wrote: On 9 December 2016 at 12:14, Yisheng Xie wrote: Hi Robert, We have merged your patch to 4.9.0-rc8, however we still meet the similar problem on our D05 board: To be clear: does this issue also occur on D05 *without* the

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 12/09/2016 08:19 PM, Ard Biesheuvel wrote: On 9 December 2016 at 12:14, Yisheng Xie wrote: Hi Robert, We have merged your patch to 4.9.0-rc8, however we still meet the similar problem on our D05 board: To be clear: does this issue also occur on D05 *without* the patch? It boots ok on

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, We have merged your patch to 4.9.0-rc8, however we still meet the similar problem on our D05 board: Thanks, Yisheng Xie - [5.081971] [ cut here ] [5.086668] kernel BUG at mm/page_alloc.c:1863! [5.091281] Internal error: Oops - BUG: 0

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, We have merged your patch to 4.9.0-rc8, however we still meet the similar problem on our D05 board: Thanks, Yisheng Xie - [5.081971] [ cut here ] [5.086668] kernel BUG at mm/page_alloc.c:1863! [5.091281] Internal error: Oops - BUG: 0

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 9 December 2016 at 12:14, Yisheng Xie wrote: > Hi Robert, > We have merged your patch to 4.9.0-rc8, however we still meet the similar > problem > on our D05 board: > To be clear: does this issue also occur on D05 *without* the patch? > - > [

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On 9 December 2016 at 12:14, Yisheng Xie wrote: > Hi Robert, > We have merged your patch to 4.9.0-rc8, however we still meet the similar > problem > on our D05 board: > To be clear: does this issue also occur on D05 *without* the patch? > - > [5.081971] [ cut

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, On 02/12/16 07:11, Robert Richter wrote: > On 01.12.16 17:26:55, James Morse wrote: >> On 01/12/16 16:45, Will Deacon wrote: >>> Thanks for sending out the new patch. Whilst I'm still a bit worried about >>> changing pfn_valid like this, I guess we'll just have to fix up any callers

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, On 02/12/16 07:11, Robert Richter wrote: > On 01.12.16 17:26:55, James Morse wrote: >> On 01/12/16 16:45, Will Deacon wrote: >>> Thanks for sending out the new patch. Whilst I'm still a bit worried about >>> changing pfn_valid like this, I guess we'll just have to fix up any callers

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

James, On 01.12.16 17:26:55, James Morse wrote: > On 01/12/16 16:45, Will Deacon wrote: > > Thanks for sending out the new patch. Whilst I'm still a bit worried about > > changing pfn_valid like this, I guess we'll just have to fix up any callers > > which suffer from this change. > >

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

James, On 01.12.16 17:26:55, James Morse wrote: > On 01/12/16 16:45, Will Deacon wrote: > > Thanks for sending out the new patch. Whilst I'm still a bit worried about > > changing pfn_valid like this, I guess we'll just have to fix up any callers > > which suffer from this change. > >

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, Will, On 01/12/16 16:45, Will Deacon wrote: > On Wed, Nov 30, 2016 at 07:21:31PM +0100, Robert Richter wrote: >> On ThunderX systems with certain memory configurations we see the >> following BUG_ON(): >> >> kernel BUG at mm/page_alloc.c:1848! >> >> This happens for some configs with

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

Hi Robert, Will, On 01/12/16 16:45, Will Deacon wrote: > On Wed, Nov 30, 2016 at 07:21:31PM +0100, Robert Richter wrote: >> On ThunderX systems with certain memory configurations we see the >> following BUG_ON(): >> >> kernel BUG at mm/page_alloc.c:1848! >> >> This happens for some configs with

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On Wed, Nov 30, 2016 at 07:21:31PM +0100, Robert Richter wrote: > On ThunderX systems with certain memory configurations we see the > following BUG_ON(): > > kernel BUG at mm/page_alloc.c:1848! > > This happens for some configs with 64k page size enabled. The BUG_ON() > checks if start and end

Re: [PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On Wed, Nov 30, 2016 at 07:21:31PM +0100, Robert Richter wrote: > On ThunderX systems with certain memory configurations we see the > following BUG_ON(): > > kernel BUG at mm/page_alloc.c:1848! > > This happens for some configs with 64k page size enabled. The BUG_ON() > checks if start and end

[PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On ThunderX systems with certain memory configurations we see the following BUG_ON(): kernel BUG at mm/page_alloc.c:1848! This happens for some configs with 64k page size enabled. The BUG_ON() checks if start and end page of a memmap range belongs to the same zone. The BUG_ON() check fails if

[PATCH v2] arm64: mm: Fix memmap to be initialized for the entire section

On ThunderX systems with certain memory configurations we see the following BUG_ON(): kernel BUG at mm/page_alloc.c:1848! This happens for some configs with 64k page size enabled. The BUG_ON() checks if start and end page of a memmap range belongs to the same zone. The BUG_ON() check fails if