Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread steve birtles
On Dec 18, 2007, at 6:33 PM, Haavard Skinnemoen wrote: On Tue, 18 Dec 2007 11:14:42 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: Hello Haavard, Please note that I'm not trying to steal the show here -- I just want That did not even come to my mind at all... I am happy with everything t

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 21:22:01 +0800 steve birtles <[EMAIL PROTECTED]> wrote: > Is there any change can we clean this up? > /* >* We wrap our port structure around the generic uart_port. > @@ -142,8 +146,8 @@ static void atmel_set_mctrl(struct uart_port > *port, u_int mctrl) > #ifdef CONFI

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 11:14:42 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Please note that I'm not trying to steal the show here -- I just want > > That did not even come to my mind at all... > I am happy with everything that helps making this driver better. Good :) >

Re: [PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Remy Bohmer
Hello Haavard, > Please note that I'm not trying to steal the show here -- I just want That did not even come to my mind at all... I am happy with everything that helps making this driver better. What shall we do first from here, splitup of the interrupt handler? Or DMA patch? Kind Regards, R

[PATCH v2] atmel_serial: Clean up the code

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch cleans up the atmel_serial driver to conform the coding rules. It contains no functional change. [EMAIL PROTECTED]: additional cleanups] Signed-off-by: Remy Bohmer <[EMAIL PROTECTED]> Signed-off-by: Haavard Skinnemoen <[EMAIL PROTECTED]> --- Change