Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-24 Thread Jeff Layton
On Tue, 2017-01-24 at 10:00 -0500, Jeff Layton wrote: > On Wed, 2017-01-18 at 07:14 -0500, Jeff Layton wrote: > > On Thu, 2017-01-12 at 12:37 +0100, Ilya Dryomov wrote: > > > On Thu, Jan 12, 2017 at 12:27 PM, Jeff Layton wrote: > > > > On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: > > > > > On

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-24 Thread Jeff Layton
On Wed, 2017-01-18 at 07:14 -0500, Jeff Layton wrote: > On Thu, 2017-01-12 at 12:37 +0100, Ilya Dryomov wrote: > > On Thu, Jan 12, 2017 at 12:27 PM, Jeff Layton wrote: > > > On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: > > > > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: > > >

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-18 Thread Jeff Layton
On Thu, 2017-01-12 at 12:37 +0100, Ilya Dryomov wrote: > On Thu, Jan 12, 2017 at 12:27 PM, Jeff Layton wrote: > > On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: > > > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: > > > > > > > > v2: fix bug in offset handling in iov_iter_pvec_si

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:53 PM, Al Viro wrote: > On Thu, Jan 12, 2017 at 12:46:42PM +0100, Ilya Dryomov wrote: >> On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: >> > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: >> > >> >> It would be a significant and wide-reaching change, bu

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Jeff Layton
On Thu, 2017-01-12 at 12:46 +0100, Ilya Dryomov wrote: > On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: > > > > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: > > > > > > > > It would be a significant and wide-reaching change, but I've been > > > meaning to look into switching

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Al Viro
On Thu, Jan 12, 2017 at 12:46:42PM +0100, Ilya Dryomov wrote: > On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: > > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: > > > >> It would be a significant and wide-reaching change, but I've been > >> meaning to look into switching to iov_i

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:37 PM, Al Viro wrote: > On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: > >> It would be a significant and wide-reaching change, but I've been >> meaning to look into switching to iov_iter for a couple of releases >> now. There is a lot of ugly code in net

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Al Viro
On Thu, Jan 12, 2017 at 12:13:31PM +0100, Ilya Dryomov wrote: > It would be a significant and wide-reaching change, but I've been > meaning to look into switching to iov_iter for a couple of releases > now. There is a lot of ugly code in net/ceph/messenger.c to hangle > iteration over "page vecto

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 12:27 PM, Jeff Layton wrote: > On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: >> On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: >> > >> > v2: fix bug in offset handling in iov_iter_pvec_size >> > >> > xfstest generic/095 triggers soft lockups in kcephfs. Ba

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Jeff Layton
On Thu, 2017-01-12 at 07:59 +, Al Viro wrote: > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: > > > > v2: fix bug in offset handling in iov_iter_pvec_size > > > > xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses > > fio to drive some I/O via vmsplice ane

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2017 at 8:59 AM, Al Viro wrote: > On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: >> v2: fix bug in offset handling in iov_iter_pvec_size >> >> xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses >> fio to drive some I/O via vmsplice ane splice. Cep

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-12 Thread Al Viro
On Tue, Jan 10, 2017 at 07:57:31AM -0500, Jeff Layton wrote: > v2: fix bug in offset handling in iov_iter_pvec_size > > xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses > fio to drive some I/O via vmsplice ane splice. Ceph then ends up trying > to access an ITER_BVEC type io

Re: [PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-10 Thread Yan, Zheng
> On 10 Jan 2017, at 20:57, Jeff Layton wrote: > > v2: fix bug in offset handling in iov_iter_pvec_size > > xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses > fio to drive some I/O via vmsplice ane splice. Ceph then ends up trying > to access an ITER_BVEC type iov_iter as

[PATCH v2] ceph/iov_iter: fix bad iov_iter handling in ceph splice codepaths

2017-01-10 Thread Jeff Layton
v2: fix bug in offset handling in iov_iter_pvec_size xfstest generic/095 triggers soft lockups in kcephfs. Basically it uses fio to drive some I/O via vmsplice ane splice. Ceph then ends up trying to access an ITER_BVEC type iov_iter as a ITER_IOVEC one. That causes it to pick up a wrong offset an