Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-25 Thread Stephen Boyd
On 04/04/14 13:19, Kumar Gala wrote: > + > +#define P_PXO0 > +#define P_PLL8 1 > +#define P_CXO2 > +#define P_PLL3 3 This #define needs to be 1. Unfortunately the way we do this mapping requires that they match the parents string array. If you have a better idea I'm

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-25 Thread Stephen Boyd
On 04/04/14 13:19, Kumar Gala wrote: + +#define P_PXO0 +#define P_PLL8 1 +#define P_CXO2 +#define P_PLL3 3 This #define needs to be 1. Unfortunately the way we do this mapping requires that they match the parents string array. If you have a better idea I'm all for

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Stephen Boyd
On 04/04, Kumar Gala wrote: > Add a driver for the global clock controller found on IPQ8064 based > platforms. This should allow most non-multimedia device drivers to probe > and control their clocks. > > This is currently missing clocks for SATA, USB, and networking devices. > > Signed-off-by:

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Ivan T. Ivanov
On Mon, 2014-04-07 at 10:10 -0500, Kumar Gala wrote: > On Apr 7, 2014, at 10:01 AM, Ivan T. Ivanov wrote: > > > Hi Kumar, > > > >> --- /dev/null > >> +++ b/drivers/clk/qcom/gcc-ipq806x.c > >> @@ -0,0 +1,1957 @@ > >> +/* > >> +#include > >> +#include > >> + > >> +#include "common.h" > >

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Kumar Gala
On Apr 7, 2014, at 10:01 AM, Ivan T. Ivanov wrote: > Hi Kumar, > > On Fri, 2014-04-04 at 15:19 -0500, Kumar Gala wrote: >> Add a driver for the global clock controller found on IPQ8064 based >> platforms. This should allow most non-multimedia device drivers to probe >> and control their

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Ivan T. Ivanov
Hi Kumar, On Fri, 2014-04-04 at 15:19 -0500, Kumar Gala wrote: > Add a driver for the global clock controller found on IPQ8064 based > platforms. This should allow most non-multimedia device drivers to probe > and control their clocks. > > This is currently missing clocks for SATA, USB, and

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Ivan T. Ivanov
Hi Kumar, On Fri, 2014-04-04 at 15:19 -0500, Kumar Gala wrote: Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control their clocks. This is currently missing clocks for SATA, USB, and

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Kumar Gala
On Apr 7, 2014, at 10:01 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: Hi Kumar, On Fri, 2014-04-04 at 15:19 -0500, Kumar Gala wrote: Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Ivan T. Ivanov
On Mon, 2014-04-07 at 10:10 -0500, Kumar Gala wrote: On Apr 7, 2014, at 10:01 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: Hi Kumar, snip --- /dev/null +++ b/drivers/clk/qcom/gcc-ipq806x.c @@ -0,0 +1,1957 @@ +/* snip +#include dt-bindings/clock/qcom,gcc-ipq806x.h +#include

Re: [PATCH v2] clk: qcom: Add support for IPQ8064's global clock controller (GCC)

2014-04-07 Thread Stephen Boyd
On 04/04, Kumar Gala wrote: Add a driver for the global clock controller found on IPQ8064 based platforms. This should allow most non-multimedia device drivers to probe and control their clocks. This is currently missing clocks for SATA, USB, and networking devices. Signed-off-by: Kumar