Re: [PATCH v2] dm ioctl: allow change device target type to error

2013-08-22 Thread Mike Snitzer
On Wed, Aug 21 2013 at 10:50pm -0400, Joe Jin wrote: > Mikulas, thanks for you suggestions, I create new patch, can you please help > review? > > Subject: dm: add map_rq define for error > > commit a5664da "dm ioctl: make bio or request based device type immutable" > prevented "dmsetup wape_tab

Re: [PATCH v2] dm ioctl: allow change device target type to error

2013-08-22 Thread Mike Snitzer
On Wed, Aug 21 2013 at 10:40pm -0400, Joe Jin wrote: > On 08/21/13 23:06, Mike Snitzer wrote: > > On Wed, Aug 21 2013 at 10:48am -0400, > > Mikulas Patocka wrote: > > > >> > >> > >> On Wed, 21 Aug 2013, Joe Jin wrote: > >> > >>> commit a5664da "dm ioctl: make bio or request based device type im

Re: [dm-devel] [PATCH v2] dm ioctl: allow change device target type to error

2013-08-21 Thread Joe Jin
Mikulas, thanks for you suggestions, I create new patch, can you please help review? Subject: dm: add map_rq define for error commit a5664da "dm ioctl: make bio or request based device type immutable" prevented "dmsetup wape_table" change the target type to "error" for there is not map_rq for err

Re: [PATCH v2] dm ioctl: allow change device target type to error

2013-08-21 Thread Joe Jin
On 08/21/13 23:06, Mike Snitzer wrote: > On Wed, Aug 21 2013 at 10:48am -0400, > Mikulas Patocka wrote: > >> >> >> On Wed, 21 Aug 2013, Joe Jin wrote: >> >>> commit a5664da "dm ioctl: make bio or request based device type immutable" >>> prevented "dmsetup wape_table" change the target type to "er

Re: [PATCH v2] dm ioctl: allow change device target type to error

2013-08-21 Thread Mike Snitzer
On Wed, Aug 21 2013 at 10:48am -0400, Mikulas Patocka wrote: > > > On Wed, 21 Aug 2013, Joe Jin wrote: > > > commit a5664da "dm ioctl: make bio or request based device type immutable" > > prevented "dmsetup wape_table" change the target type to "error". > > That commit a5664da is there for a

Re: [dm-devel] [PATCH v2] dm ioctl: allow change device target type to error

2013-08-21 Thread Mikulas Patocka
On Wed, 21 Aug 2013, Joe Jin wrote: > commit a5664da "dm ioctl: make bio or request based device type immutable" > prevented "dmsetup wape_table" change the target type to "error". That commit a5664da is there for a reason (it is not possible to change bio-based device to request-based and vic

[PATCH v2] dm ioctl: allow change device target type to error

2013-08-21 Thread Joe Jin
commit a5664da "dm ioctl: make bio or request based device type immutable" prevented "dmsetup wape_table" change the target type to "error". -v2: setup md->queue even target type is "error". Signed-off-by: Joe Jin --- drivers/md/dm-ioctl.c | 4 drivers/md/dm-table.c | 12 dri