Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 09:02:49AM -0800, Davidlohr Bueso wrote: > On Wed, 30 Nov 2016, Greg KH wrote: > > What changed from v1? Please always include it below the --- line to > > keep maintainer's semi-sane. > > If anything changed I would have -- this is only the From != SoB thing > you were

Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 09:02:49AM -0800, Davidlohr Bueso wrote: > On Wed, 30 Nov 2016, Greg KH wrote: > > What changed from v1? Please always include it below the --- line to > > keep maintainer's semi-sane. > > If anything changed I would have -- this is only the From != SoB thing > you were

Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Davidlohr Bueso
On Wed, 30 Nov 2016, Greg KH wrote: What changed from v1? Please always include it below the --- line to keep maintainer's semi-sane. If anything changed I would have -- this is only the From != SoB thing you were complaining about. There's nothing to try again, this is a trivial.

Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Davidlohr Bueso
On Wed, 30 Nov 2016, Greg KH wrote: What changed from v1? Please always include it below the --- line to keep maintainer's semi-sane. If anything changed I would have -- this is only the From != SoB thing you were complaining about. There's nothing to try again, this is a trivial.

Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 05:49:26AM -0800, Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant drivers/base/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag

Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Greg KH
On Wed, Nov 30, 2016 at 05:49:26AM -0800, Davidlohr Bueso wrote: > With the new standardized functions, we can replace all ACCESS_ONCE() > calls across relevant drivers/base/. > > ACCESS_ONCE() does not work reliably on non-scalar types. For example > gcc 4.6 and 4.7 might remove the volatile tag

[PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Davidlohr Bueso
With the new standardized functions, we can replace all ACCESS_ONCE() calls across relevant drivers/base/. ACCESS_ONCE() does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step:

[PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

2016-11-30 Thread Davidlohr Bueso
With the new standardized functions, we can replace all ACCESS_ONCE() calls across relevant drivers/base/. ACCESS_ONCE() does not work reliably on non-scalar types. For example gcc 4.6 and 4.7 might remove the volatile tag for such accesses during the SRA (scalar replacement of aggregates) step: