Re: [PATCH v2] drivers/perf: xgene_pmu: Fix uninitialized resource struct

2020-09-14 Thread Will Deacon
On Mon, Sep 14, 2020 at 09:13:39AM -0400, Mark Salter wrote: > On Mon, 2020-09-14 at 12:28 +0100, Will Deacon wrote: > > On Sun, Sep 13, 2020 at 01:45:36PM -0400, Mark Salter wrote: > > > @@ -1483,11 +1473,23 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct > > > xgene_pmu *xgene_pmu, > > >

Re: [PATCH v2] drivers/perf: xgene_pmu: Fix uninitialized resource struct

2020-09-14 Thread Mark Salter
On Mon, 2020-09-14 at 12:28 +0100, Will Deacon wrote: > On Sun, Sep 13, 2020 at 01:45:36PM -0400, Mark Salter wrote: > > @@ -1483,11 +1473,23 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct > > xgene_pmu *xgene_pmu, > > return NULL; > > > > INIT_LIST_HEAD(_list); > > - rc =

Re: [PATCH v2] drivers/perf: xgene_pmu: Fix uninitialized resource struct

2020-09-14 Thread Will Deacon
On Sun, Sep 13, 2020 at 01:45:36PM -0400, Mark Salter wrote: > @@ -1483,11 +1473,23 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct > xgene_pmu *xgene_pmu, > return NULL; > > INIT_LIST_HEAD(_list); > - rc = acpi_dev_get_resources(adev, _list, > -

[PATCH v2] drivers/perf: xgene_pmu: Fix uninitialized resource struct

2020-09-13 Thread Mark Salter
This splat was reported on newer Fedora kernels booting on certain X-gene based machines: xgene-pmu APMC0D83:00: X-Gene PMU version 3 Unable to handle kernel read from unreadable memory at virtual \ address 4006 ... Call trace: string+0x50/0x100 vsnprintf+0x160/0x750