Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
On Tue, Jul 23, 2019 at 02:07:39PM -0700, David Miller wrote: > From: David Miller > Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT) > > > From: Kelsey Skunberg > > Date: Tue, 23 Jul 2019 12:58:11 -0600 > > > >> acpi_evaluate_object will already return an error if the needed method > >> does not

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
On Tue, Jul 23, 2019 at 05:56:04PM -0500, Bjorn Helgaas wrote: > On Tue, Jul 23, 2019 at 1:59 PM Kelsey Skunberg > wrote: > > > > acpi_evaluate_object will already return an error if the needed method > > does not exist. Remove unnecessary acpi_has_method() calls and check the > > returned

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Bjorn Helgaas
On Tue, Jul 23, 2019 at 1:59 PM Kelsey Skunberg wrote: > > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > diff --git

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread David Miller
From: David Miller Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT) > From: Kelsey Skunberg > Date: Tue, 23 Jul 2019 12:58:11 -0600 > >> acpi_evaluate_object will already return an error if the needed method >> does not exist. Remove unnecessary acpi_has_method() calls and check the >> returned

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread David Miller
From: Kelsey Skunberg Date: Tue, 23 Jul 2019 12:58:11 -0600 > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > > Signed-off-by: Kelsey Skunberg > --- >

[PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
acpi_evaluate_object will already return an error if the needed method does not exist. Remove unnecessary acpi_has_method() calls and check the returned acpi_status for failure instead. Signed-off-by: Kelsey Skunberg --- Changes in v2: - Fixed white space warnings and errors