Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-23 Thread Sean Paul
On Mon, Feb 20, 2017 at 08:08:15AM +0100, Christophe JAILLET wrote: > It is likely that both 'clk_disable_unprepare()' should be called if > 'pm_runtime_get_sync()' fails. > > Add a new label for that, because 'err_set_rate' is not meaningful in this > case. > > Add a missing call to

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-23 Thread Sean Paul
On Mon, Feb 20, 2017 at 08:08:15AM +0100, Christophe JAILLET wrote: > It is likely that both 'clk_disable_unprepare()' should be called if > 'pm_runtime_get_sync()' fails. > > Add a new label for that, because 'err_set_rate' is not meaningful in this > case. > > Add a missing call to

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-19 Thread Mark yao
On 2017年02月20日 15:08, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Add a missing call to 'pm_runtime_put()'. Fixes: 1a0f7ed3abe2

Re: [PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-19 Thread Mark yao
On 2017年02月20日 15:08, Christophe JAILLET wrote: It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Add a missing call to 'pm_runtime_put()'. Fixes: 1a0f7ed3abe2

[PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-19 Thread Christophe JAILLET
It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Add a missing call to 'pm_runtime_put()'. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for

[PATCH v2] drm/rockchip: cdn-dp: Fix error handling

2017-02-19 Thread Christophe JAILLET
It is likely that both 'clk_disable_unprepare()' should be called if 'pm_runtime_get_sync()' fails. Add a new label for that, because 'err_set_rate' is not meaningful in this case. Add a missing call to 'pm_runtime_put()'. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for