Re: [PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Dawid Kurek
On 15/06/17, Sean Paul wrote: > On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > > Smaller scope reduces visibility of variable and makes usage of > > uninitialized variable less possible. > > > > Changes in v2: > > - separate declaration and initialization > > Your patch is

Re: [PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Dawid Kurek
On 15/06/17, Sean Paul wrote: > On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > > Smaller scope reduces visibility of variable and makes usage of > > uninitialized variable less possible. > > > > Changes in v2: > > - separate declaration and initialization > > Your patch is

Re: [PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Sean Paul
On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > Smaller scope reduces visibility of variable and makes usage of > uninitialized variable less possible. > > Changes in v2: > - separate declaration and initialization Your patch is missing Signed-off-by tag Sean > --- >

Re: [PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Sean Paul
On Thu, Jun 15, 2017 at 04:04:36PM +0200, Dawid Kurek wrote: > Smaller scope reduces visibility of variable and makes usage of > uninitialized variable less possible. > > Changes in v2: > - separate declaration and initialization Your patch is missing Signed-off-by tag Sean > --- >

[PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Dawid Kurek
Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. Changes in v2: - separate declaration and initialization --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2] drm: Reduce scope of 'state' variable

2017-06-15 Thread Dawid Kurek
Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. Changes in v2: - separate declaration and initialization --- drivers/gpu/drm/drm_atomic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git