Re: [PATCH v2] eventfd: convert to ->write_iter()

2020-11-21 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 07:46:10PM +0100, Michal Kubecek wrote: > On Thu, Nov 19, 2020 at 06:03:15PM +, Christoph Hellwig wrote: > > On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote: > > > While eventfd ->read() callback was replaced by ->read_iter() recently by > > > commit

Re: [PATCH v2] eventfd: convert to ->write_iter()

2020-11-19 Thread Michal Kubecek
On Thu, Nov 19, 2020 at 06:03:15PM +, Christoph Hellwig wrote: > On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote: > > While eventfd ->read() callback was replaced by ->read_iter() recently by > > commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write() > > was

Re: [PATCH v2] eventfd: convert to ->write_iter()

2020-11-19 Thread Jens Axboe
On 11/19/20 11:03 AM, Christoph Hellwig wrote: > On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote: >> While eventfd ->read() callback was replaced by ->read_iter() recently by >> commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write() >> was not replaced. >> >>

Re: [PATCH v2] eventfd: convert to ->write_iter()

2020-11-19 Thread Christoph Hellwig
On Thu, Nov 19, 2020 at 07:00:19PM +0100, Michal Kubecek wrote: > While eventfd ->read() callback was replaced by ->read_iter() recently by > commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write() > was not replaced. > > Convert also ->write() to ->write_iter() to make the

[PATCH v2] eventfd: convert to ->write_iter()

2020-11-19 Thread Michal Kubecek
While eventfd ->read() callback was replaced by ->read_iter() recently by commit 12aceb89b0bc ("eventfd: convert to f_op->read_iter()"), ->write() was not replaced. Convert also ->write() to ->write_iter() to make the interface more consistent and allow non-blocking writes from e.g. io_uring.