Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 10:05, Yunlong Song wrote: > So I use CHECK_FS config to control it. When CHECK_FS is off, all the > other f2fs_bug_on also > only printk WARNING info rather than trigger BUG_ON. If this runing out-of-free-segments issue explicitly happens, IMO, its better to face and fix it. BTW,

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 10:05, Yunlong Song wrote: > So I use CHECK_FS config to control it. When CHECK_FS is off, all the > other f2fs_bug_on also > only printk WARNING info rather than trigger BUG_ON. If this runing out-of-free-segments issue explicitly happens, IMO, its better to face and fix it. BTW,

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
So I use CHECK_FS config to control it. When CHECK_FS is off, all the other f2fs_bug_on also only printk WARNING info rather than trigger BUG_ON. On 2017/10/31 9:59, Chao Yu wrote: On 2017/10/31 9:33, Yunlong Song wrote: ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case,

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
So I use CHECK_FS config to control it. When CHECK_FS is off, all the other f2fs_bug_on also only printk WARNING info rather than trigger BUG_ON. On 2017/10/31 9:59, Chao Yu wrote: On 2017/10/31 9:33, Yunlong Song wrote: ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case,

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 9:33, Yunlong Song wrote: > ping... > > On 2017/9/1 20:00, Yunlong Song wrote: >> In come corner case, the reserved segments are used to do gc, and there are >> not enough free segments for write checkpoint to finish its job, then the >> gc process will fail to change the prefree

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 9:33, Yunlong Song wrote: > ping... > > On 2017/9/1 20:00, Yunlong Song wrote: >> In come corner case, the reserved segments are used to do gc, and there are >> not enough free segments for write checkpoint to finish its job, then the >> gc process will fail to change the prefree

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song

[PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-09-01 Thread Yunlong Song
In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 10

[PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-09-01 Thread Yunlong Song
In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 10 ++ 1 file