Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-11-02 Thread Jeff Moyer
Jens Axboe writes: > On 10/30/2015 09:34 AM, Jeff Moyer wrote: >> From: Vivek Goyal >> >> If a block device is hot removed and later last reference to device >> is put, we try to writeback the dirty inode. But device is gone and >> that writeback fails. >> >> Currently we do a WARN_ON() which

Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-11-02 Thread Jeff Moyer
Jens Axboe writes: > On 10/30/2015 09:34 AM, Jeff Moyer wrote: >> From: Vivek Goyal >> >> If a block device is hot removed and later last reference to device >> is put, we try to writeback the dirty inode. But device is gone and >> that writeback fails. >> >>

Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-10-30 Thread Jens Axboe
On 10/30/2015 09:34 AM, Jeff Moyer wrote: From: Vivek Goyal If a block device is hot removed and later last reference to device is put, we try to writeback the dirty inode. But device is gone and that writeback fails. Currently we do a WARN_ON() which does not seem to be the right thing.

[PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-10-30 Thread Jeff Moyer
From: Vivek Goyal If a block device is hot removed and later last reference to device is put, we try to writeback the dirty inode. But device is gone and that writeback fails. Currently we do a WARN_ON() which does not seem to be the right thing. Convert it to a ratelimited kernel warning.

Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-10-30 Thread Jens Axboe
On 10/30/2015 09:34 AM, Jeff Moyer wrote: From: Vivek Goyal If a block device is hot removed and later last reference to device is put, we try to writeback the dirty inode. But device is gone and that writeback fails. Currently we do a WARN_ON() which does not seem to be

[PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

2015-10-30 Thread Jeff Moyer
From: Vivek Goyal If a block device is hot removed and later last reference to device is put, we try to writeback the dirty inode. But device is gone and that writeback fails. Currently we do a WARN_ON() which does not seem to be the right thing. Convert it to a ratelimited