On Wed, Oct 28, 2020 at 9:24 PM Andy Shevchenko
wrote:
>
> On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote:
> > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch
> > wrote:
>
> ...
>
> > > +#include
> >
> > Please keep the includes ordered alphabetically.
>
> Besides the fact that th
On Wed, Oct 28, 2020 at 09:25:32PM +0100, Andy Shevchenko wrote:
> On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote:
> > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id gpio_mockup_of_match[] = {
> > > + { .compatibl
On Tue, Oct 27, 2020 at 07:12:13PM +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch
> wrote:
> > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
> > index 67ed4f238d43..c93892a6936a 100644
> > --- a/drivers/gpio/gpio-mockup.c
> > +++ b/dri
On Wed, Oct 28, 2020 at 10:00 AM Vincent Whitchurch
wrote:
>
> Allow the mockup driver to be probed via the device tree without any
> module parameters, allowing it to be used to configure and test higher
> level drivers like the leds-gpio driver and corresponding userspace
> before actual hardwar
On Wed, Oct 28, 2020 at 10:25 PM Andy Shevchenko
wrote:
> On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote:
...
> It's not so. If you drop ugly ifdeffery (and I vote for that, see also
It's not so -> It's not so simple.
> above) the of_match_ptr() must be dropped as well.
> Otherwise
On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch
> wrote:
...
> > +#include
>
> Please keep the includes ordered alphabetically.
Besides the fact that that is a wrong header to be included.
mod_devicetable.h is the correct one.
(S
On Wed, Oct 28, 2020 at 12:43:22PM +0100, Andy Shevchenko wrote:
> On Wed, Oct 28, 2020 at 10:00 AM Vincent Whitchurch
> wrote:
> > Allow the mockup driver to be probed via the device tree without any
> > module parameters, allowing it to be used to configure and test higher
> > level drivers like
On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch
wrote:
>
> Allow the mockup driver to be probed via the device tree without any
> module parameters, allowing it to be used to configure and test higher
> level drivers like the leds-gpio driver and corresponding userspace
> before actual hardware
Allow the mockup driver to be probed via the device tree without any
module parameters, allowing it to be used to configure and test higher
level drivers like the leds-gpio driver and corresponding userspace
before actual hardware is available.
Signed-off-by: Vincent Whitchurch
---
v2: Remove mos
9 matches
Mail list logo