Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-27 Thread Alexander Holler
Am 26.03.2014 23:37, schrieb Alexander Holler: Am 26.03.2014 22:55, schrieb Alexander Holler: Am 26.03.2014 22:38, schrieb Levente Kurusa: This is walkable but probably not worth the effort. Besides, why would anyone want to put spaces, colons and arbitrary characters to filenames in the

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-27 Thread Alexander Holler
Am 26.03.2014 23:37, schrieb Alexander Holler: Am 26.03.2014 22:55, schrieb Alexander Holler: Am 26.03.2014 22:38, schrieb Levente Kurusa: This is walkable but probably not worth the effort. Besides, why would anyone want to put spaces, colons and arbitrary characters to filenames in the

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 26.03.2014 22:55, schrieb Alexander Holler: Am 26.03.2014 22:38, schrieb Levente Kurusa: What I think might be reasonable is: - get rid of the dependency list in form of a include into the Makefile and just generate the cpio-archive every time make is called. Common initramfs sizes are

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 26.03.2014 22:38, schrieb Levente Kurusa: Hi, 2014-03-26 22:16 GMT+01:00 Alexander Holler : Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler wrote: Am 21.03.2014 22:03, schrieb Andrew

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Levente Kurusa
Hi, 2014-03-26 22:16 GMT+01:00 Alexander Holler : > Am 22.03.2014 00:07, schrieb Alexander Holler: >> >> Am 21.03.2014 23:55, schrieb Andrew Morton: >> >>> On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler >>> wrote: >>> Am 21.03.2014 22:03, schrieb Andrew Morton: > > On Thu, 20

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler wrote: Am 21.03.2014 22:03, schrieb Andrew Morton: On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler wrote: The initramfs generation is

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 21.03.2014 22:03, schrieb Andrew Morton: On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler hol...@ahsoftware.de

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Levente Kurusa
Hi, 2014-03-26 22:16 GMT+01:00 Alexander Holler hol...@ahsoftware.de: Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 21.03.2014 22:03, schrieb Andrew Morton: On

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 26.03.2014 22:38, schrieb Levente Kurusa: Hi, 2014-03-26 22:16 GMT+01:00 Alexander Holler hol...@ahsoftware.de: Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-26 Thread Alexander Holler
Am 26.03.2014 22:55, schrieb Alexander Holler: Am 26.03.2014 22:38, schrieb Levente Kurusa: What I think might be reasonable is: - get rid of the dependency list in form of a include into the Makefile and just generate the cpio-archive every time make is called. Common initramfs sizes are

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-22 Thread Alexander Holler
Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: Should we check for \t and \n as well? Hmm, maybe. But usually there aren't filenames wich do contain those characters, and if you want to break (or exploit) the kernel build process, there are easier

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-22 Thread Alexander Holler
Am 22.03.2014 00:07, schrieb Alexander Holler: Am 21.03.2014 23:55, schrieb Andrew Morton: Should we check for \t and \n as well? Hmm, maybe. But usually there aren't filenames wich do contain those characters, and if you want to break (or exploit) the kernel build process, there are easier

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Alexander Holler
Am 21.03.2014 23:55, schrieb Andrew Morton: > On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler > wrote: > >> Am 21.03.2014 22:03, schrieb Andrew Morton: >>> On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler >>> wrote: >>> The initramfs generation is broken for file and directory

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Andrew Morton
On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler wrote: > Am 21.03.2014 22:03, schrieb Andrew Morton: > > On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler > > wrote: > > > >> The initramfs generation is broken for file and directory names which > >> contain > >> colons or spaces.

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Alexander Holler
Am 21.03.2014 22:03, schrieb Andrew Morton: > On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler > wrote: > >> The initramfs generation is broken for file and directory names which contain >> colons or spaces. Print an error and don't try to continue. > It would be better to fix the

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Andrew Morton
On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler wrote: > The initramfs generation is broken for file and directory names which contain > colons or spaces. Print an error and don't try to continue. > > Tests: > > cd linux > make defconfig > echo 'CONFIG_BLK_DEV_INITRD=y' >> .config > echo

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Andrew Morton
On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler hol...@ahsoftware.de wrote: The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. Tests: cd linux make defconfig echo 'CONFIG_BLK_DEV_INITRD=y'

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Alexander Holler
Am 21.03.2014 22:03, schrieb Andrew Morton: On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler hol...@ahsoftware.de wrote: The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. It would be better to fix

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Andrew Morton
On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 21.03.2014 22:03, schrieb Andrew Morton: On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler hol...@ahsoftware.de wrote: The initramfs generation is broken for file and directory names which contain

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-21 Thread Alexander Holler
Am 21.03.2014 23:55, schrieb Andrew Morton: On Fri, 21 Mar 2014 23:49:57 +0100 Alexander Holler hol...@ahsoftware.de wrote: Am 21.03.2014 22:03, schrieb Andrew Morton: On Thu, 20 Mar 2014 23:00:45 +0100 Alexander Holler hol...@ahsoftware.de wrote: The initramfs generation is broken for

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-20 Thread Alexander Holler
Am 20.03.2014 23:00, schrieb Alexander Holler: The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. I will not send a v3, but I think this is a candidate for the stable kernels too, as the problem might drive

[PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-20 Thread Alexander Holler
The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. Tests: cd linux make defconfig echo 'CONFIG_BLK_DEV_INITRD=y' >> .config echo 'CONFIG_INITRAMFS_ROOT_UID=0' >>.config echo 'CONFIG_INITRAMFS_ROOT_GID=0'

[PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-20 Thread Alexander Holler
The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. Tests: cd linux make defconfig echo 'CONFIG_BLK_DEV_INITRD=y' .config echo 'CONFIG_INITRAMFS_ROOT_UID=0' .config echo 'CONFIG_INITRAMFS_ROOT_GID=0' .config

Re: [PATCH v2] initramfs: print error and shell out for unsupported content

2014-03-20 Thread Alexander Holler
Am 20.03.2014 23:00, schrieb Alexander Holler: The initramfs generation is broken for file and directory names which contain colons or spaces. Print an error and don't try to continue. I will not send a v3, but I think this is a candidate for the stable kernels too, as the problem might drive