Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 17:30:10 CET schrieb Masahiro Yamada: > > That way the conf tool will sanitize the .config before shell scripts will > > source it. > > This approach seems better. Okay, let's go for it. :) I went first for the ugly bash approach because it is a white list and not

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 17:30:10 CET schrieb Masahiro Yamada: > > That way the conf tool will sanitize the .config before shell scripts will > > source it. > > This approach seems better. Okay, let's go for it. :) I went first for the ugly bash approach because it is a white list and not

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-21 1:16 GMT+09:00 Richard Weinberger : > Am Dienstag, 20. Februar 2018, 17:00:39 CET schrieb Masahiro Yamada: >> 2018-02-21 0:25 GMT+09:00 Richard Weinberger : >> > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: >> >> 2018-02-19 18:22

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-21 1:16 GMT+09:00 Richard Weinberger : > Am Dienstag, 20. Februar 2018, 17:00:39 CET schrieb Masahiro Yamada: >> 2018-02-21 0:25 GMT+09:00 Richard Weinberger : >> > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: >> >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger : >>

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Nicolas Pitre
On Tue, 20 Feb 2018, Richard Weinberger wrote: > An alternate approach would be this: > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index 5c12dc91ef34..ff0a7c62344b 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -161,6 +161,13 @@

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Nicolas Pitre
On Tue, 20 Feb 2018, Richard Weinberger wrote: > An alternate approach would be this: > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index 5c12dc91ef34..ff0a7c62344b 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -161,6 +161,13 @@

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 17:00:39 CET schrieb Masahiro Yamada: > 2018-02-21 0:25 GMT+09:00 Richard Weinberger : > > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: > >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger : > >> > Don't source

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 17:00:39 CET schrieb Masahiro Yamada: > 2018-02-21 0:25 GMT+09:00 Richard Weinberger : > > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: > >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger : > >> > Don't source the kernel config file in shell

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-21 0:25 GMT+09:00 Richard Weinberger : > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger : >> > Don't source the kernel config file in shell scripts. >> > The config file is not a shell

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-21 0:25 GMT+09:00 Richard Weinberger : > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger : >> > Don't source the kernel config file in shell scripts. >> > The config file is not a shell script and often imported from

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: > 2018-02-19 18:22 GMT+09:00 Richard Weinberger : > > Don't source the kernel config file in shell scripts. > > The config file is not a shell script and often imported from untrusted > > sources. > > What could

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Richard Weinberger
Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: > 2018-02-19 18:22 GMT+09:00 Richard Weinberger : > > Don't source the kernel config file in shell scripts. > > The config file is not a shell script and often imported from untrusted > > sources. > > What could possible go

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-19 18:22 GMT+09:00 Richard Weinberger : > Don't source the kernel config file in shell scripts. > The config file is not a shell script and often imported from untrusted > sources. > What could possible go wrong? ;-) Please enumerate your real problems. > Instead, read

Re: [PATCH v2] kbuild: Don't source kernel config

2018-02-20 Thread Masahiro Yamada
2018-02-19 18:22 GMT+09:00 Richard Weinberger : > Don't source the kernel config file in shell scripts. > The config file is not a shell script and often imported from untrusted > sources. > What could possible go wrong? ;-) Please enumerate your real problems. > Instead, read config file line

[PATCH v2] kbuild: Don't source kernel config

2018-02-19 Thread Richard Weinberger
Don't source the kernel config file in shell scripts. The config file is not a shell script and often imported from untrusted sources. What could possible go wrong? ;-) Instead, read config file line by line and access config entries using a bash array. Cc: Sam Ravnborg Cc:

[PATCH v2] kbuild: Don't source kernel config

2018-02-19 Thread Richard Weinberger
Don't source the kernel config file in shell scripts. The config file is not a shell script and often imported from untrusted sources. What could possible go wrong? ;-) Instead, read config file line by line and access config entries using a bash array. Cc: Sam Ravnborg Cc: Arnaud Lacombe Cc: