Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-15 Thread Miguel Ojeda
On Fri, Jan 15, 2021 at 11:55 PM Masahiro Yamada wrote: > > Yes, I plan to merge scripts/ld-version.sh and scripts/lld-version.sh > in a similar way, and move the version check as well > once the following cleanups land in the upstream: > >

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-15 Thread Masahiro Yamada
On Fri, Jan 15, 2021 at 3:15 AM Miguel Ojeda wrote: > > On Thu, Jan 14, 2021 at 5:25 AM Masahiro Yamada wrote: > > > > The cc-version.sh also shows the error if the compiler is old: > > > > $ make defconfig CC=clang-9 > > *** Default configuration is based on 'x86_64_defconfig' > > *** > >

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Miguel Ojeda
On Thu, Jan 14, 2021 at 5:25 AM Masahiro Yamada wrote: > > The cc-version.sh also shows the error if the compiler is old: > > $ make defconfig CC=clang-9 > *** Default configuration is based on 'x86_64_defconfig' > *** > *** Compiler is too old. > *** Your Clang version:9.0.1 >

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Nathan Chancellor
On Thu, Jan 14, 2021 at 01:24:19PM +0900, Masahiro Yamada wrote: > Paul Gortmaker reported a regression in the GCC version check [1]. > If you use GCC 4.8, the build breaks before showing the error message > "error Sorry, your version of GCC is too old - please use 4.9 or newer." > > I do not

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Nathan Chancellor
On Thu, Jan 14, 2021 at 06:20:15PM +0900, Masahiro Yamada wrote: > BTW, when I tried ICC a few years ago, > I could not build the kernel with it. Looking at the history behind include/linux/compiler-intel.h, the last time I see a change that actually references building a kernel with icc was

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Masahiro Yamada
On Thu, Jan 14, 2021 at 4:55 PM Ilie Halip wrote: > > Hi Masahiro, > > > + #elif defined(__INTEL_COMPILER) > > + /* How to get the version of intel compiler? */ > > + ICC 0 0 0 > > According to Intel documentation[1], this should do the trick: > >

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:55 AM Ilie Halip wrote: > > Hi Masahiro, > > > + #elif defined(__INTEL_COMPILER) > > + /* How to get the version of intel compiler? */ > > + ICC 0 0 0 > > According to Intel documentation[1], this should do the trick: > >

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Ilie Halip
Hi Masahiro, > + #elif defined(__INTEL_COMPILER) > + /* How to get the version of intel compiler? */ > + ICC 0 0 0 According to Intel documentation[1], this should do the trick: ICC __INTEL_COMPILER __INTEL_COMPILER_UPDATE

[PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Masahiro Yamada
Paul Gortmaker reported a regression in the GCC version check [1]. If you use GCC 4.8, the build breaks before showing the error message "error Sorry, your version of GCC is too old - please use 4.9 or newer." I do not want to apply his fix-up since it implies we would not be able to remove any