Re: Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-05-12 Thread Hidehiro Kawai
Hi all, What is the current status of this bug fix patch? I think it's OK if resending Hatayama-san's patch with Ingo's. Thanks, (2015/03/25 2:04), Vivek Goyal wrote: > On Tue, Mar 24, 2015 at 05:18:14PM +0100, Ingo Molnar wrote: >> >> * Vivek Goyal wrote: >> Yet the actual bug is in that

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-25 Thread Hidehiro Kawai
Hello all, (2015/03/24 23:32), Vivek Goyal wrote: > On Tue, Mar 24, 2015 at 05:27:10AM -0500, Eric W. Biederman wrote: >> Ingo Molnar writes: >> >>> * Masami Hiramatsu wrote: >>> > > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option > for kdump after panic_not

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 05:18:14PM +0100, Ingo Molnar wrote: > > * Vivek Goyal wrote: > > > > Yet the actual bug is in that commit, 'crash_kexec_post_notifiers' > > > was clearly not a no-op in the default case, against expectations. > > > > Hi Ingo, > > > > I did a quick test and in default

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Ingo Molnar
* Vivek Goyal wrote: > > Yet the actual bug is in that commit, 'crash_kexec_post_notifiers' > > was clearly not a no-op in the default case, against expectations. > > Hi Ingo, > > I did a quick test and in default case crash_kexec() runs before > panic notifiers. So it does look like crash_k

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 08:11:29AM +0100, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > (2015/03/23 16:19), Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > >> CC more people ... > > >> > > >> On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > >>> The commit f06

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 05:27:10AM -0500, Eric W. Biederman wrote: > Ingo Molnar writes: > > > * Masami Hiramatsu wrote: > > > >> > > >> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option > >> > for kdump after panic_notifers") > >> > > >> > Was that crash_kexec() was

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Eric W. Biederman
Ingo Molnar writes: > * Masami Hiramatsu wrote: > >> > >> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option >> > for kdump after panic_notifers") >> > >> > Was that crash_kexec() was called unconditionally after notifiers were >> > called, which should be fixed via t

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Ingo Molnar
* Masami Hiramatsu wrote: > (2015/03/23 16:19), Ingo Molnar wrote: > > > > * Baoquan He wrote: > > > >> CC more people ... > >> > >> On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > >>> The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > >>> "crash_kexec_post_notifiers"

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Masami Hiramatsu
(2015/03/23 23:31), Vivek Goyal wrote: [...] Secondly, and more importantly, the whole premise of commit f06e5153f4ae is broken IMHO: "This can help rare situations where kdump fails because of unstable crashed kernel or hardware failure (memory corruption on critical >

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Masami Hiramatsu
(2015/03/23 16:19), Ingo Molnar wrote: > > * Baoquan He wrote: > >> CC more people ... >> >> On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: >>> The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced >>> "crash_kexec_post_notifiers" kernel boot option, which toggles >>> wheather

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Don Zickus
On Mon, Mar 23, 2015 at 10:31:58AM -0400, Vivek Goyal wrote: > > > I think one of the motivations behind this patch was call to kmsg_dump(). > > > Some vendors have been wanting to have the capability to save kernel logs > > > to some NVRAM before transition to second kernel happens. Their argument

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > * Baoquan He wrote: > > > CC more people ... > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > > "crash_kexec_post_notifiers" kernel boot opti

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
On Mon, Mar 23, 2015 at 02:50:46PM +0100, Ingo Molnar wrote: > > * Vivek Goyal wrote: > > > On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > > > CC more people ... > > > > > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: >

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Ingo Molnar
* Vivek Goyal wrote: > On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > > > * Baoquan He wrote: > > > > > CC more people ... > > > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > > > "cr

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > * Baoquan He wrote: > > > CC more people ... > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > > "crash_kexec_post_notifiers" kernel boot opti

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Ingo Molnar
* Baoquan He wrote: > CC more people ... > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > "crash_kexec_post_notifiers" kernel boot option, which toggles > > wheather panic() calls crash_kexec() before panic_notif

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-22 Thread Baoquan He
CC more people ... On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > "crash_kexec_post_notifiers" kernel boot option, which toggles > wheather panic() calls crash_kexec() before panic_notifiers and dump > kmsg or after. > >

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-06 Thread Vivek Goyal
On Sat, Mar 07, 2015 at 01:31:01AM +0900, "Hatayama, Daisuke/畑山 大輔" wrote: > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > "crash_kexec_post_notifiers" kernel boot option, which toggles > wheather panic() calls crash_kexec() before panic_notifiers and dump > kmsg or after. > > T

[PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-06 Thread Hatayama, Daisuke/畑山 大輔
The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced "crash_kexec_post_notifiers" kernel boot option, which toggles wheather panic() calls crash_kexec() before panic_notifiers and dump kmsg or after. The problem is that the commit overlooks panic_on_oops kernel boot option. If it is enab