On 9/2/19 6:52 AM, Petr Mladek wrote:
On Fri 2019-08-30 16:37:10, Brendan Higgins wrote:
On Fri, Aug 30, 2019 at 11:22:43PM +, tim.b...@sony.com wrote:
-Original Message-
From: Brendan Higgins
On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
On Fri, 2019-08-30 at 21:58 +,
On Fri 2019-08-30 16:37:10, Brendan Higgins wrote:
> On Fri, Aug 30, 2019 at 11:22:43PM +, tim.b...@sony.com wrote:
> > > -Original Message-
> > > From: Brendan Higgins
> > >
> > > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
> > > >
> > > > On Fri, 2019-08-30 at 21:58 +,
> -Original Message-
> From: Brendan Higgins
>
> On Fri, Aug 30, 2019 at 11:22:43PM +, tim.b...@sony.com wrote:
> > > -Original Message-
> > > From: Brendan Higgins
> > >
> > > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
> > > >
> > > > On Fri, 2019-08-30 at 21:58
On Fri, 2019-08-30 at 16:37 -0700, Brendan Higgins wrote:
> I thought you and Joe were arguing that "Joe's" resulted in a smaller
> object size than "Mine" (not to be confused with the actual patch I
> presented here, which is what Sergey suggested I do on a different
> thread).
>
> I really
On Fri, Aug 30, 2019 at 11:22:43PM +, tim.b...@sony.com wrote:
> > -Original Message-
> > From: Brendan Higgins
> >
> > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
> > >
> > > On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > > > > From: Joe Perches
> > > []
> >
On Fri, 2019-08-30 at 23:22 +, tim.b...@sony.com wrote:
> > -Original Message-
> > From: Brendan Higgins
> >
> > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
> > > On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > > > > From: Joe Perches
> > > []
> > > > IMHO %pV
> -Original Message-
> From: Joe Perches
>
> On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > > From: Joe Perches
> []
> > IMHO %pV should be avoided if possible. Just because people are
> > doing it doesn't mean it should be used when it is not necessary.
>
> Well,
> -Original Message-
> From: Brendan Higgins
>
> On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
> >
> > On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > > > From: Joe Perches
> > []
> > > IMHO %pV should be avoided if possible. Just because people are
> > > doing it
On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote:
>
> On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > > From: Joe Perches
> []
> > IMHO %pV should be avoided if possible. Just because people are
> > doing it doesn't mean it should be used when it is not necessary.
>
> Well, as
On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote:
> > From: Joe Perches
[]
> IMHO %pV should be avoided if possible. Just because people are
> doing it doesn't mean it should be used when it is not necessary.
Well, as the guy that created %pV, I of course
have a different opinion.
> >
> -Original Message-
> From: Joe Perches
>
> On Fri, 2019-08-30 at 11:38 -0700, Brendan Higgins wrote:
> > On Thu, Aug 29, 2019 at 09:44:58PM -0700, Joe Perches wrote:
> > > On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:
> > > > On 8/28/19 3:49 AM, Sergey Senozhatsky wrote:
> > > > >
On Fri, 2019-08-30 at 11:38 -0700, Brendan Higgins wrote:
> On Thu, Aug 29, 2019 at 09:44:58PM -0700, Joe Perches wrote:
> > On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:
> > > On 8/28/19 3:49 AM, Sergey Senozhatsky wrote:
> > > > On (08/28/19 02:31), Brendan Higgins wrote:
> > > > [..]
> > > >
On Thu, Aug 29, 2019 at 09:44:58PM -0700, Joe Perches wrote:
> On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:
> > On 8/28/19 3:49 AM, Sergey Senozhatsky wrote:
> > > On (08/28/19 02:31), Brendan Higgins wrote:
> > > [..]
> > > > Previously KUnit assumed that printk would always be present, which
On (08/29/19 11:01), shuah wrote:
[..]
> Hi Sergey,
>
> What are the guidelines for using printk(). I recall some discussion
> about not using printk(). I am seeing the following from checkpatch
> script:
Hello,
> WARNING: Prefer [subsystem eg: netdev]_level([subsystem]dev, ... then
>
On Thu, 2019-08-29 at 21:44 -0700, Joe Perches wrote:
> On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:
[]
> > WARNING: Prefer [subsystem eg: netdev]_level([subsystem]dev, ... then
> > dev_level(dev, ... then pr_level(... to printk(KERN_LEVEL ...
> > #105: FILE: include/kunit/test.h:343:
> > +
On Thu, 2019-08-29 at 11:01 -0600, shuah wrote:
> On 8/28/19 3:49 AM, Sergey Senozhatsky wrote:
> > On (08/28/19 02:31), Brendan Higgins wrote:
> > [..]
> > > Previously KUnit assumed that printk would always be present, which is
> > > not a valid assumption to make. Fix that by removing call to
>
On 8/28/19 3:49 AM, Sergey Senozhatsky wrote:
On (08/28/19 02:31), Brendan Higgins wrote:
[..]
Previously KUnit assumed that printk would always be present, which is
not a valid assumption to make. Fix that by removing call to
vprintk_emit, and calling printk directly.
Reported-by: Randy
On 8/28/19 2:31 AM, Brendan Higgins wrote:
> Previously KUnit assumed that printk would always be present, which is
> not a valid assumption to make. Fix that by removing call to
> vprintk_emit, and calling printk directly.
>
> Reported-by: Randy Dunlap
> Link:
>
On Wed 2019-08-28 18:49:29, Sergey Senozhatsky wrote:
> On (08/28/19 02:31), Brendan Higgins wrote:
> [..]
> > Previously KUnit assumed that printk would always be present, which is
> > not a valid assumption to make. Fix that by removing call to
> > vprintk_emit, and calling printk directly.
> >
On (08/28/19 02:31), Brendan Higgins wrote:
[..]
> Previously KUnit assumed that printk would always be present, which is
> not a valid assumption to make. Fix that by removing call to
> vprintk_emit, and calling printk directly.
>
> Reported-by: Randy Dunlap
> Link:
>
Previously KUnit assumed that printk would always be present, which is
not a valid assumption to make. Fix that by removing call to
vprintk_emit, and calling printk directly.
Reported-by: Randy Dunlap
Link:
21 matches
Mail list logo
