Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-20 Thread Jakub Kicinski
On Thu, 19 Nov 2020 22:34:46 +0200 Grygorii Strashko wrote: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned which from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-20 Thread Andrew Lunn
Hi Joe > reverse xmas tree is completely crazy. > > But I posted a patch to checkpatch to suggest it for net/ > and drivers/net/ once > > https://lkml.org/lkml/2016/11/4/54 > From Joe Perches <> > ... > and the reverse xmas tree helpfulness of looking up the > type of bar is neither

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Joe Perches
On Thu, 2020-11-19 at 21:21 -0800, Jakub Kicinski wrote: > We do have our own comment style rule in networking since the beginning > of time, and reverse xmas tree, so it's not completely crazy. reverse xmas tree is completely crazy. But I posted a patch to checkpatch to suggest it for net/ and

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Jakub Kicinski
On Thu, 19 Nov 2020 23:09:52 +0100 Heiner Kallweit wrote: > Am 19.11.2020 um 22:41 schrieb Andrew Lunn: > Doesn't checkpatch complain about line length > 80 here? > >>> > >>> :) > >>> > >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > >>> Author: Joe Perches > >>> Date:   Fri May 29

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 22:41 schrieb Andrew Lunn: Doesn't checkpatch complain about line length > 80 here? >>> >>> :) >>> >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 >>> Author: Joe Perches >>> Date:   Fri May 29 16:12:21 2020 -0700 >>> >>>     checkpatch/coding-style: deprecate 80-column

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Andrew Lunn
> >> Doesn't checkpatch complain about line length > 80 here? > > > > :) > > > > commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Author: Joe Perches > > Date:   Fri May 29 16:12:21 2020 -0700 > > > >     checkpatch/coding-style: deprecate 80-column warning > > > > Ah, again something

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 22:17 schrieb Grygorii Strashko: > > > On 19/11/2020 23:11, Heiner Kallweit wrote: >> Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: >>> The mdio_bus may have dependencies from GPIO controller and so got >>> deferred. Now it will print error message every time -EPROBE_DEFER

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 23:11, Heiner Kallweit wrote: Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register()

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned which from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually identifying

[PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register() |-devm_gpiod_get_optional() without actually identifying error code. "mdio_bus 4a101000.mdio: mii_bus 4a101000.mdio