Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-12 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2020 13:58:51 +0900 Alexandre Courbot escreveu: > Hi Mauro, > > On Fri, Oct 9, 2020 at 3:34 PM Mauro Carvalho Chehab > wrote: > > > > Em Fri, 9 Oct 2020 13:30:06 +0900 > > Alexandre Courbot escreveu: > > > > > On Fri, Oct 9, 2020 at 1:13 AM Hans Verkuil > > > wrote: > >

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-11 Thread Alexandre Courbot
Hi Mauro, On Fri, Oct 9, 2020 at 3:34 PM Mauro Carvalho Chehab wrote: > > Em Fri, 9 Oct 2020 13:30:06 +0900 > Alexandre Courbot escreveu: > > > On Fri, Oct 9, 2020 at 1:13 AM Hans Verkuil > > wrote: > > > > >>> If VIDEO_MEDIATEK_VPU=y and MTK_SCP=m, then VIDEO_MEDIATEK_VCODEC can > > > >>> be

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-08 Thread Alexandre Courbot
On Fri, Oct 9, 2020 at 1:13 AM Hans Verkuil wrote: > > On 08/10/2020 16:02, Alexandre Courbot wrote: > > Hi Hans, thanks for taking the time to look at this! > > > > On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil > > wrote: > >> > >> On 08/10/2020 15:07, Hans Verkuil wrote: > >>> Hi Alexandre, > >

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-08 Thread Hans Verkuil
On 08/10/2020 16:02, Alexandre Courbot wrote: > Hi Hans, thanks for taking the time to look at this! > > On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil wrote: >> >> On 08/10/2020 15:07, Hans Verkuil wrote: >>> Hi Alexandre, >>> >>> On 04/10/2020 14:22, Alexandre Courbot wrote: The addition of

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-08 Thread Alexandre Courbot
Hi Hans, thanks for taking the time to look at this! On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil wrote: > > On 08/10/2020 15:07, Hans Verkuil wrote: > > Hi Alexandre, > > > > On 04/10/2020 14:22, Alexandre Courbot wrote: > >> The addition of MT8183 support added a dependency on the SCP remotepro

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-08 Thread Hans Verkuil
On 08/10/2020 15:07, Hans Verkuil wrote: > Hi Alexandre, > > On 04/10/2020 14:22, Alexandre Courbot wrote: >> The addition of MT8183 support added a dependency on the SCP remoteproc >> module. However the initial patch used the "select" Kconfig directive, >> which may result in the SCP module to n

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-08 Thread Hans Verkuil
Hi Alexandre, On 04/10/2020 14:22, Alexandre Courbot wrote: > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc was > disabled. In su

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-05 Thread Alexandre Courbot
On Mon, Oct 5, 2020 at 5:49 PM Sakari Ailus wrote: > > Hi Alexandre, > > On Sun, Oct 04, 2020 at 09:22:34PM +0900, Alexandre Courbot wrote: > > The addition of MT8183 support added a dependency on the SCP remoteproc > > module. However the initial patch used the "select" Kconfig directive, > > whi

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-05 Thread Sakari Ailus
Hi Alexandre, On Sun, Oct 04, 2020 at 09:22:34PM +0900, Alexandre Courbot wrote: > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc

Re: [PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-04 Thread Alexandre Courbot
On Sun, Oct 4, 2020 at 9:22 PM Alexandre Courbot wrote: > > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc was > disabled. In such

[PATCH v2] media: mtk-vcodec: fix builds when remoteproc is disabled

2020-10-04 Thread Alexandre Courbot
The addition of MT8183 support added a dependency on the SCP remoteproc module. However the initial patch used the "select" Kconfig directive, which may result in the SCP module to not be compiled if remoteproc was disabled. In such a case, mtk-vcodec would try to link against non-existent SCP symb