Re: [PATCH v2] memcg: refactor mem_cgroup_resize_limit()

2017-06-04 Thread kbuild test robot
Hi Yu, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.12-rc3 next-20170602] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yu-Zhao/memcg-refactor-mem_cgroup_resize_limit/20

Re: [PATCH v2] memcg: refactor mem_cgroup_resize_limit()

2017-06-04 Thread kbuild test robot
Hi Yu, [auto build test ERROR on mmotm/master] [also build test ERROR on v4.12-rc3 next-20170602] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yu-Zhao/memcg-refactor-mem_cgroup_resize_limit/20

Re: [PATCH v2] memcg: refactor mem_cgroup_resize_limit()

2017-06-04 Thread Yu Zhao
On Sun, Jun 04, 2017 at 11:09:42PM +0300, Vladimir Davydov wrote: > On Sun, Jun 04, 2017 at 01:04:37PM -0700, Yu Zhao wrote: > > @@ -2498,22 +2449,24 @@ static int mem_cgroup_resize_memsw_limit(struct > > mem_cgroup *memcg, > > } > > > > mutex_lock(&memcg_limit_mutex); >

Re: [PATCH v2] memcg: refactor mem_cgroup_resize_limit()

2017-06-04 Thread Vladimir Davydov
On Sun, Jun 04, 2017 at 01:04:37PM -0700, Yu Zhao wrote: > @@ -2498,22 +2449,24 @@ static int mem_cgroup_resize_memsw_limit(struct > mem_cgroup *memcg, > } > > mutex_lock(&memcg_limit_mutex); > - if (limit < memcg->memory.limit) { > + inverted

[PATCH v2] memcg: refactor mem_cgroup_resize_limit()

2017-06-04 Thread Yu Zhao
mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have identical logics. Refactor code so we don't need to keep two pieces of code that does same thing. Signed-off-by: Yu Zhao Acked-by: Vladimir Davydov --- Changelog since v1: * minor style change mm/memcontrol.c | 73 ++---