Re:Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Bernard
] memory/samsung: reduce unnecessary mutex lock area> > >On 5/12/20 12:40 PM, Markus Elfring wrote: >>> Maybe dmc->df->lock seems not needed to protect "if (ret) >>> & dev_warn" branch. Maybe this change speed up the code a bit. >> >> I s

Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Lukasz Luba
On 5/12/20 12:40 PM, Markus Elfring wrote: Maybe dmc->df->lock seems not needed to protect "if (ret) & dev_warn" branch. Maybe this change speed up the code a bit. I suggest to improve also this commit message. * Please reduce uncertainty. * An imperative wording is probably preferred,

Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Markus Elfring
> Maybe dmc->df->lock seems not needed to protect "if (ret) > & dev_warn" branch. Maybe this change speed up the code a bit. I suggest to improve also this commit message. * Please reduce uncertainty. * An imperative wording is probably preferred, isn't it?

[PATCH v2] memory/samsung: reduce unnecessary mutex lock area

2020-05-12 Thread Bernard Zhao
Maybe dmc->df->lock seems not needed to protect "if (ret) & dev_warn" branch. Maybe this change speed up the code a bit. Signed-off-by: Bernard Zhao Changes since v1: *change release lock before the if statement. *revert dmc->df->lock mutex lock to protect function