Re: [PATCH v2] misc: sram: fix check of devm_ioremap*() return value

2016-04-17 Thread Vladimir Zapolskiy
Hi Greg, On 23.03.2016 04:52, Vladimir Zapolskiy wrote: > Both devm_ioremap() and devm_ioremap_wc() functions return either > a pointer to valid iomem region or NULL, check for IS_ERR() is improper > and may result in oops on error path. Now on error -ENOMEM is returned. > > Fixes: 0ab163ad1ea0 (

[PATCH v2] misc: sram: fix check of devm_ioremap*() return value

2016-03-22 Thread Vladimir Zapolskiy
Both devm_ioremap() and devm_ioremap_wc() functions return either a pointer to valid iomem region or NULL, check for IS_ERR() is improper and may result in oops on error path. Now on error -ENOMEM is returned. Fixes: 0ab163ad1ea0 ("misc: sram: switch to ioremap_wc from ioremap") Signed-off-by: Vla