Re: [PATCH v2] mm/oom_kill.c: remove the unmatched comments

2020-10-27 Thread Michal Hocko
On Tue 27-10-20 23:11:56, Hui Su wrote: > On Tue, Oct 27, 2020 at 03:58:14PM +0100, Michal Hocko wrote: > > On Tue 27-10-20 22:45:29, Hui Su wrote: > > > is_dump_unreclaim_slabs() just check whether nr_unreclaimable > > > slabs amount is greater than user memory, not match witch comment. > > > >

Re: [PATCH v2] mm/oom_kill.c: remove the unmatched comments

2020-10-27 Thread Michal Hocko
On Tue 27-10-20 22:45:29, Hui Su wrote: > is_dump_unreclaim_slabs() just check whether nr_unreclaimable > slabs amount is greater than user memory, not match witch comment. As I've tried to explain, the comment is not explaining what the function does but how it should be used. It is not a

Re: [PATCH v2] mm/oom_kill.c: remove the unmatched comments

2020-10-27 Thread Hui Su
On Tue, Oct 27, 2020 at 03:58:14PM +0100, Michal Hocko wrote: > On Tue 27-10-20 22:45:29, Hui Su wrote: > > is_dump_unreclaim_slabs() just check whether nr_unreclaimable > > slabs amount is greater than user memory, not match witch comment. > > As I've tried to explain, the comment is not

[PATCH v2] mm/oom_kill.c: remove the unmatched comments

2020-10-27 Thread Hui Su
is_dump_unreclaim_slabs() just check whether nr_unreclaimable slabs amount is greater than user memory, not match witch comment. So delete the comment, and rename it to should_dump_unreclaim_slabs(). Signed-off-by: Hui Su --- mm/oom_kill.c | 8 ++-- 1 file changed, 2 insertions(+), 6