On Sat, Nov 14, 2020 at 10:50:39AM -0800, Andrew Morton wrote:
> On Sat, 14 Nov 2020 13:51:34 +0800 Hui Su wrote:
>
> > inline the shmem_mapping(), and use shmem_mapping()
> > instead of 'inode->i_mapping->a_ops == _aops'
> > in shmem_evict_inode().
> >
> > ...
> >
> > --- a/mm/shmem.c
> > +++
On Sat, Nov 14, 2020 at 10:50:39AM -0800, Andrew Morton wrote:
> But really, shmem_mapping() isn't worth an out-of-line call from any
> callsite - it would be best to make it inlined everywhere.
>
> - make shmem_aops global
> - declare shmem_aops in shmem_fs.h
> - export shmem_aops to modules for
On Sat, 14 Nov 2020 13:51:34 +0800 Hui Su wrote:
> inline the shmem_mapping(), and use shmem_mapping()
> instead of 'inode->i_mapping->a_ops == _aops'
> in shmem_evict_inode().
>
> ...
>
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -1152,7 +1152,7 @@ static void shmem_evict_inode(struct inode
inline the shmem_mapping(), and use shmem_mapping()
instead of 'inode->i_mapping->a_ops == _aops'
in shmem_evict_inode().
v1->v2:
remove the inline for func declaration in shmem_fs.h
Reviewed-by: Pankaj Gupta
Reported-by: kernel test robot
Signed-off-by: Hui Su
---
mm/shmem.c | 4 ++--
1
4 matches
Mail list logo