Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-29 Thread Soeren Moch
On 29.01.2013 12:02, Andrew Lunn wrote: Now I activated the debug messages in em28xx. From the messages I see no correlation of the pool exhaustion and lost sync. Also I cannot see any error messages from the em28xx driver. I see a lot of init_isoc/stop_urbs (maybe EPG scan?) without draining

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-29 Thread Andrew Lunn
> Now I activated the debug messages in em28xx. From the messages I > see no correlation of the pool exhaustion and lost sync. Also I > cannot see any error messages from the em28xx driver. > I see a lot of init_isoc/stop_urbs (maybe EPG scan?) without > draining the coherent pool (checked with

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-29 Thread Andrew Lunn
Now I activated the debug messages in em28xx. From the messages I see no correlation of the pool exhaustion and lost sync. Also I cannot see any error messages from the em28xx driver. I see a lot of init_isoc/stop_urbs (maybe EPG scan?) without draining the coherent pool (checked with 'cat

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-29 Thread Soeren Moch
On 29.01.2013 12:02, Andrew Lunn wrote: Now I activated the debug messages in em28xx. From the messages I see no correlation of the pool exhaustion and lost sync. Also I cannot see any error messages from the em28xx driver. I see a lot of init_isoc/stop_urbs (maybe EPG scan?) without draining

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-28 Thread Jason Cooper
On Mon, Jan 28, 2013 at 09:59:18PM +0100, Soeren Moch wrote: > On 23.01.2013 19:10, Andrew Lunn wrote: > > >>> > >>>Now (in the last hour) stable, occasionally lower numbers: > >>>3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >>>3396 3396 3396 3396 3396 3396 3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-28 Thread Soeren Moch
On 23.01.2013 19:10, Andrew Lunn wrote: Now (in the last hour) stable, occasionally lower numbers: 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-28 Thread Soeren Moch
On 23.01.2013 19:10, Andrew Lunn wrote: Now (in the last hour) stable, occasionally lower numbers: 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-28 Thread Jason Cooper
On Mon, Jan 28, 2013 at 09:59:18PM +0100, Soeren Moch wrote: On 23.01.2013 19:10, Andrew Lunn wrote: Now (in the last hour) stable, occasionally lower numbers: 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
> >> > > > >Now (in the last hour) stable, occasionally lower numbers: > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 > >3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 23.01.2013 18:07, Soeren Moch wrote: On 23.01.2013 17:25, Andrew Lunn wrote: On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 23.01.2013 17:25, Andrew Lunn wrote: On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: > On 19.01.2013 19:59, Andrew Lunn wrote: > >>Please find attached a debug log generated with your patch. > >> > >>I used the sata disk and two em28xx dvb sticks, no other usb devices, > >>no ethernet cable connected, tuners on

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable connected, tuners on saa716x-based card not used. What I can see in the log: a lot of coherent mappings

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 22.01.2013 19:13, Arnd Bergmann wrote: On Monday 21 January 2013, Greg KH wrote: I don't know a lot about USB, but I always assumed that this was not a normal condition and that there are only a couple of URBs per endpoint used at a time. Maybe Greg or someone else with a USB background can

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 22.01.2013 19:13, Arnd Bergmann wrote: On Monday 21 January 2013, Greg KH wrote: I don't know a lot about USB, but I always assumed that this was not a normal condition and that there are only a couple of URBs per endpoint used at a time. Maybe Greg or someone else with a USB background can

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable connected, tuners on saa716x-based card not used. What I can see in the log: a lot of coherent mappings

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable connected, tuners on saa716x-based card not

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 23.01.2013 17:25, Andrew Lunn wrote: On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Soeren Moch
On 23.01.2013 18:07, Soeren Moch wrote: On 23.01.2013 17:25, Andrew Lunn wrote: On Wed, Jan 23, 2013 at 04:30:53PM +0100, Soeren Moch wrote: On 19.01.2013 19:59, Andrew Lunn wrote: Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-23 Thread Andrew Lunn
Now (in the last hour) stable, occasionally lower numbers: 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396 3396

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-22 Thread Arnd Bergmann
On Monday 21 January 2013, Greg KH wrote: > > > > I don't know a lot about USB, but I always assumed that this was not > > a normal condition and that there are only a couple of URBs per endpoint > > used at a time. Maybe Greg or someone else with a USB background can > > shed some light on this.

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-22 Thread Arnd Bergmann
On Monday 21 January 2013, Greg KH wrote: I don't know a lot about USB, but I always assumed that this was not a normal condition and that there are only a couple of URBs per endpoint used at a time. Maybe Greg or someone else with a USB background can shed some light on this.

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 06:55:25PM +, Arnd Bergmann wrote: > On Monday 21 January 2013, Soeren Moch wrote: > > On 01/19/13 21:05, Arnd Bergmann wrote: > > > from the distribution of the numbers, it seems that there is exactly 1 MB > > > of data allocated between bus addresses 0x1f9 and

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Soeren Moch wrote: > On 01/19/13 21:05, Arnd Bergmann wrote: > > from the distribution of the numbers, it seems that there is exactly 1 MB > > of data allocated between bus addresses 0x1f9 and 0x1f9, allocated > > in individual pages. This matches the size of

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Soeren Moch
On 01/19/13 21:05, Arnd Bergmann wrote: I found at least one source line that incorrectly uses an atomic allocation, in ehci_mem_init(): dma_alloc_coherent (ehci_to_hcd(ehci)->self.controller, ehci->periodic_size * sizeof(__le32),

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Soeren Moch
On 01/19/13 21:05, Arnd Bergmann wrote: I found at least one source line that incorrectly uses an atomic allocation, in ehci_mem_init(): dma_alloc_coherent (ehci_to_hcd(ehci)-self.controller, ehci-periodic_size * sizeof(__le32),

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Soeren Moch wrote: On 01/19/13 21:05, Arnd Bergmann wrote: from the distribution of the numbers, it seems that there is exactly 1 MB of data allocated between bus addresses 0x1f9 and 0x1f9, allocated in individual pages. This matches the size of your pool,

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 06:55:25PM +, Arnd Bergmann wrote: On Monday 21 January 2013, Soeren Moch wrote: On 01/19/13 21:05, Arnd Bergmann wrote: from the distribution of the numbers, it seems that there is exactly 1 MB of data allocated between bus addresses 0x1f9 and 0x1f9,

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Arnd Bergmann
On Saturday 19 January 2013, Soeren Moch wrote: > What I can see in the log: a lot of coherent mappings from sata_mv and > orion_ehci, a few from mv643xx_eth, no other coherent mappings. > All coherent mappings are page aligned, some of them (from orion_ehci) > are not really small (as claimed in

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
> Please find attached a debug log generated with your patch. > > I used the sata disk and two em28xx dvb sticks, no other usb devices, > no ethernet cable connected, tuners on saa716x-based card not used. > > What I can see in the log: a lot of coherent mappings from sata_mv > and orion_ehci, a

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
On Thu, Jan 17, 2013 at 08:26:45PM +, Arnd Bergmann wrote: > On Thursday 17 January 2013, Soeren Moch wrote: > > On 17.01.2013 11:49, Arnd Bergmann wrote: > > > On Wednesday 16 January 2013, Soeren Moch wrote: > > I will see what I can do here. Is there an easy way to track the buffer > >

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
On Thu, Jan 17, 2013 at 08:26:45PM +, Arnd Bergmann wrote: On Thursday 17 January 2013, Soeren Moch wrote: On 17.01.2013 11:49, Arnd Bergmann wrote: On Wednesday 16 January 2013, Soeren Moch wrote: I will see what I can do here. Is there an easy way to track the buffer usage

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Andrew Lunn
Please find attached a debug log generated with your patch. I used the sata disk and two em28xx dvb sticks, no other usb devices, no ethernet cable connected, tuners on saa716x-based card not used. What I can see in the log: a lot of coherent mappings from sata_mv and orion_ehci, a few

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-19 Thread Arnd Bergmann
On Saturday 19 January 2013, Soeren Moch wrote: What I can see in the log: a lot of coherent mappings from sata_mv and orion_ehci, a few from mv643xx_eth, no other coherent mappings. All coherent mappings are page aligned, some of them (from orion_ehci) are not really small (as claimed in

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Arnd Bergmann
On Thursday 17 January 2013, Soeren Moch wrote: > On 17.01.2013 11:49, Arnd Bergmann wrote: > > On Wednesday 16 January 2013, Soeren Moch wrote: > I will see what I can do here. Is there an easy way to track the buffer > usage without having to wait for complete exhaustion? > >>> > >>>

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Soeren Moch
On 17.01.2013 11:49, Arnd Bergmann wrote: On Wednesday 16 January 2013, Soeren Moch wrote: I will see what I can do here. Is there an easy way to track the buffer usage without having to wait for complete exhaustion? DMA_API_DEBUG OK, maybe I can try this. Any success with this? It

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Arnd Bergmann
On Wednesday 16 January 2013, Soeren Moch wrote: > >> I will see what I can do here. Is there an easy way to track the buffer > >> usage without having to wait for complete exhaustion? > > > > DMA_API_DEBUG > > OK, maybe I can try this. > > Any success with this? It should at least tell you if

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Arnd Bergmann
On Wednesday 16 January 2013, Soeren Moch wrote: I will see what I can do here. Is there an easy way to track the buffer usage without having to wait for complete exhaustion? DMA_API_DEBUG OK, maybe I can try this. Any success with this? It should at least tell you if there is a

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Soeren Moch
On 17.01.2013 11:49, Arnd Bergmann wrote: On Wednesday 16 January 2013, Soeren Moch wrote: I will see what I can do here. Is there an easy way to track the buffer usage without having to wait for complete exhaustion? DMA_API_DEBUG OK, maybe I can try this. Any success with this? It

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-17 Thread Arnd Bergmann
On Thursday 17 January 2013, Soeren Moch wrote: On 17.01.2013 11:49, Arnd Bergmann wrote: On Wednesday 16 January 2013, Soeren Moch wrote: I will see what I can do here. Is there an easy way to track the buffer usage without having to wait for complete exhaustion? DMA_API_DEBUG OK,

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 18:47, Jason Cooper wrote: On Wed, Jan 16, 2013 at 06:32:09PM +0100, Soeren Moch wrote: On 16.01.2013 09:55, Soeren Moch wrote: On 16.01.2013 04:24, Soeren Moch wrote: I did not bisect it, but Marek mentioned earlier that commit e9da6e9905e639b0f842a244bc770b48ad0523e9 in Linux

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Jason Cooper
On Wed, Jan 16, 2013 at 06:32:09PM +0100, Soeren Moch wrote: > On 16.01.2013 09:55, Soeren Moch wrote: > >On 16.01.2013 04:24, Soeren Moch wrote: > >>I did not bisect it, but Marek mentioned earlier that commit > >>e9da6e9905e639b0f842a244bc770b48ad0523e9 in Linux v3.6-rc1 introduced > >>new code

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 09:55, Soeren Moch wrote: On 16.01.2013 04:24, Soeren Moch wrote: On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 04:24, Soeren Moch wrote: On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 04:24, Soeren Moch wrote: On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 09:55, Soeren Moch wrote: On 16.01.2013 04:24, Soeren Moch wrote: On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Jason Cooper
On Wed, Jan 16, 2013 at 06:32:09PM +0100, Soeren Moch wrote: On 16.01.2013 09:55, Soeren Moch wrote: On 16.01.2013 04:24, Soeren Moch wrote: I did not bisect it, but Marek mentioned earlier that commit e9da6e9905e639b0f842a244bc770b48ad0523e9 in Linux v3.6-rc1 introduced new code for dma

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-16 Thread Soeren Moch
On 16.01.2013 18:47, Jason Cooper wrote: On Wed, Jan 16, 2013 at 06:32:09PM +0100, Soeren Moch wrote: On 16.01.2013 09:55, Soeren Moch wrote: On 16.01.2013 04:24, Soeren Moch wrote: I did not bisect it, but Marek mentioned earlier that commit e9da6e9905e639b0f842a244bc770b48ad0523e9 in Linux

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Soeren Moch
On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: > On 15.01.2013 22:56, Jason Cooper wrote: > >On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: > >>If my understanding is correct, one of the drivers (most likely one) > >>either asks for too small of a dma buffer,

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Soeren Moch
On 15.01.2013 22:56, Jason Cooper wrote: Soeren, On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either asks for too small of a dma buffer, or is not properly deallocating blocks from the per-device pool.

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Soeren, On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: > If my understanding is correct, one of the drivers (most likely one) > either asks for too small of a dma buffer, or is not properly > deallocating blocks from the per-device pool. Either case leads to > exhaustion, and

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:05:50PM +0100, Sebastian Hesselbarth wrote: > If we look for a mem leak in one of the above drivers (including sata_mv), > is there an easy way to keep track of allocated and freed kernel memory? I'm inclined to think sata_mv is not the cause here, as there are many

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:50:20AM -0800, Greg KH wrote: > On Tue, Jan 15, 2013 at 11:56:42AM -0500, Jason Cooper wrote: > > Greg, > > > > I've added you to the this thread hoping for a little insight into USB > > drivers and their use of coherent and GFP_ATOMIC. Am I barking up the > > wrong

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Sebastian Hesselbarth
On 01/15/2013 05:56 PM, Jason Cooper wrote: Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by looking a the drivers? On Mon, Jan 14, 2013 at 12:56:57PM +0100, Soeren Moch wrote: On

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Greg KH
On Tue, Jan 15, 2013 at 11:56:42AM -0500, Jason Cooper wrote: > Greg, > > I've added you to the this thread hoping for a little insight into USB > drivers and their use of coherent and GFP_ATOMIC. Am I barking up the > wrong tree by looking a the drivers? I don't understand, which drivers are

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by looking a the drivers? On Mon, Jan 14, 2013 at 12:56:57PM +0100, Soeren Moch wrote: > On 20.11.2012 15:31, Marek Szyprowski wrote: >

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Soeren Moch
On 15.01.2013 22:56, Jason Cooper wrote: Soeren, On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either asks for too small of a dma buffer, or is not properly deallocating blocks from the per-device pool.

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either asks for too small of a dma buffer, or is not

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Soeren Moch
On 16.01.2013 03:40, Jason Cooper wrote: Soeren, On Wed, Jan 16, 2013 at 01:17:59AM +0100, Soeren Moch wrote: On 15.01.2013 22:56, Jason Cooper wrote: On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by looking a the drivers? On Mon, Jan 14, 2013 at 12:56:57PM +0100, Soeren Moch wrote: On 20.11.2012 15:31, Marek Szyprowski wrote:

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Greg KH
On Tue, Jan 15, 2013 at 11:56:42AM -0500, Jason Cooper wrote: Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by looking a the drivers? I don't understand, which drivers are you

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Sebastian Hesselbarth
On 01/15/2013 05:56 PM, Jason Cooper wrote: Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by looking a the drivers? On Mon, Jan 14, 2013 at 12:56:57PM +0100, Soeren Moch wrote: On

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:50:20AM -0800, Greg KH wrote: On Tue, Jan 15, 2013 at 11:56:42AM -0500, Jason Cooper wrote: Greg, I've added you to the this thread hoping for a little insight into USB drivers and their use of coherent and GFP_ATOMIC. Am I barking up the wrong tree by

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:05:50PM +0100, Sebastian Hesselbarth wrote: If we look for a mem leak in one of the above drivers (including sata_mv), is there an easy way to keep track of allocated and freed kernel memory? I'm inclined to think sata_mv is not the cause here, as there are many heavy

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Soeren, On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: If my understanding is correct, one of the drivers (most likely one) either asks for too small of a dma buffer, or is not properly deallocating blocks from the per-device pool. Either case leads to exhaustion, and falling

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-14 Thread Soeren Moch
On 20.11.2012 15:31, Marek Szyprowski wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency memory pools without any good reason. Additionaly, on ARM architecture any driver which is using

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-14 Thread Soeren Moch
On 20.11.2012 15:31, Marek Szyprowski wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency memory pools without any good reason. Additionaly, on ARM architecture any driver which is using

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-22 Thread Marek Szyprowski
On 11/21/2012 8:17 PM, Andrew Morton wrote: On Wed, 21 Nov 2012 10:20:07 +0100 Marek Szyprowski wrote: > On 11/21/2012 9:36 AM, Andrew Morton wrote: > > On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski wrote: > > > On 11/20/2012 8:33 PM, Andrew Morton wrote: > > > > On Tue, 20 Nov 2012

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-22 Thread Marek Szyprowski
On 11/21/2012 8:17 PM, Andrew Morton wrote: On Wed, 21 Nov 2012 10:20:07 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: On 11/21/2012 9:36 AM, Andrew Morton wrote: On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: On 11/20/2012 8:33 PM, Andrew

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Andrew Morton
On Wed, 21 Nov 2012 10:20:07 +0100 Marek Szyprowski wrote: > Hello, > > On 11/21/2012 9:36 AM, Andrew Morton wrote: > > On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski > > wrote: > > > > > Hello, > > > > > > On 11/20/2012 8:33 PM, Andrew Morton wrote: > > > > On Tue, 20 Nov 2012 15:31:45

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Marek Szyprowski
Hello, On 11/21/2012 9:36 AM, Andrew Morton wrote: On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski wrote: > Hello, > > On 11/20/2012 8:33 PM, Andrew Morton wrote: > > On Tue, 20 Nov 2012 15:31:45 +0100 > > Marek Szyprowski wrote: > > > > > dmapool always calls dma_alloc_coherent() with

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Andrew Morton
On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski wrote: > Hello, > > On 11/20/2012 8:33 PM, Andrew Morton wrote: > > On Tue, 20 Nov 2012 15:31:45 +0100 > > Marek Szyprowski wrote: > > > > > dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, > > > regardless the flags provided

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Marek Szyprowski
Hello, On 11/20/2012 8:33 PM, Andrew Morton wrote: On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski wrote: > dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, > regardless the flags provided by the caller. This causes excessive > pruning of emergency memory pools without any

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Marek Szyprowski
Hello, On 11/20/2012 8:33 PM, Andrew Morton wrote: On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Andrew Morton
On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/20/2012 8:33 PM, Andrew Morton wrote: On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag,

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Marek Szyprowski
Hello, On 11/21/2012 9:36 AM, Andrew Morton wrote: On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/20/2012 8:33 PM, Andrew Morton wrote: On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: dmapool

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-21 Thread Andrew Morton
On Wed, 21 Nov 2012 10:20:07 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/21/2012 9:36 AM, Andrew Morton wrote: On Wed, 21 Nov 2012 09:08:52 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/20/2012 8:33 PM, Andrew Morton wrote: On

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Jason Cooper
On Tue, Nov 20, 2012 at 11:33:25AM -0800, Andrew Morton wrote: > On Tue, 20 Nov 2012 15:31:45 +0100 > Marek Szyprowski wrote: > > > dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, > > regardless the flags provided by the caller. This causes excessive > > pruning of emergency

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Andrew Morton
On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski wrote: > dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, > regardless the flags provided by the caller. This causes excessive > pruning of emergency memory pools without any good reason. Additionaly, > on ARM architecture any

[PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Marek Szyprowski
dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency memory pools without any good reason. Additionaly, on ARM architecture any driver which is using dmapools will sooner or later trigger the

[PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Marek Szyprowski
dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency memory pools without any good reason. Additionaly, on ARM architecture any driver which is using dmapools will sooner or later trigger the

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Andrew Morton
On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of emergency memory pools without any good reason. Additionaly, on ARM

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Jason Cooper
On Tue, Nov 20, 2012 at 11:33:25AM -0800, Andrew Morton wrote: On Tue, 20 Nov 2012 15:31:45 +0100 Marek Szyprowski m.szyprow...@samsung.com wrote: dmapool always calls dma_alloc_coherent() with GFP_ATOMIC flag, regardless the flags provided by the caller. This causes excessive pruning of