Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-06-04 Thread Ulf Hansson
On Mon, 3 Jun 2019 at 20:41, Doug Anderson wrote: > > Ulf, > > On Tue, May 28, 2019 at 3:49 PM Doug Anderson wrote: > > > > > 1) As kind of stated above, did you consider a solution where the core > > > simply disables the SDIO IRQ in case it isn't enabled for system > > > wakeup? In this way

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-06-03 Thread Doug Anderson
Ulf, On Tue, May 28, 2019 at 3:49 PM Doug Anderson wrote: > > > 1) As kind of stated above, did you consider a solution where the core > > simply disables the SDIO IRQ in case it isn't enabled for system > > wakeup? In this way all host drivers would benefit. > > I can give it a shot if you can

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-05-28 Thread Doug Anderson
Hi, On Tue, May 28, 2019 at 12:22 PM Ulf Hansson wrote: > > On Mon, 29 Apr 2019 at 22:41, Douglas Anderson wrote: > > > > Processing SDIO interrupts while dw_mmc is suspended (or partly > > suspended) seems like a bad idea. We really don't want to be > > processing them until we've gotten

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-05-28 Thread Ulf Hansson
On Mon, 29 Apr 2019 at 22:41, Douglas Anderson wrote: > > Processing SDIO interrupts while dw_mmc is suspended (or partly > suspended) seems like a bad idea. We really don't want to be > processing them until we've gotten ourselves fully powered up. I fully agree. Although, this is important

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-05-28 Thread Doug Anderson
Hi, On Tue, May 28, 2019 at 6:12 AM Ulf Hansson wrote: > > On Mon, 20 May 2019 at 20:41, Doug Anderson wrote: > > > > Hi, > > > > On Mon, Apr 29, 2019 at 1:41 PM Douglas Anderson > > wrote: > > > > > > Processing SDIO interrupts while dw_mmc is suspended (or partly > > > suspended) seems like

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-05-28 Thread Ulf Hansson
On Mon, 20 May 2019 at 20:41, Doug Anderson wrote: > > Hi, > > On Mon, Apr 29, 2019 at 1:41 PM Douglas Anderson > wrote: > > > > Processing SDIO interrupts while dw_mmc is suspended (or partly > > suspended) seems like a bad idea. We really don't want to be > > processing them until we've

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

2019-05-28 Thread Shawn Lin
On 2019/4/30 4:40, Douglas Anderson wrote: Processing SDIO interrupts while dw_mmc is suspended (or partly suspended) seems like a bad idea. We really don't want to be processing them until we've gotten ourselves fully powered up. You might be wondering how it's even possible to become

Re: [PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-05-20 Thread Doug Anderson
Hi, On Mon, Apr 29, 2019 at 1:41 PM Douglas Anderson wrote: > > Processing SDIO interrupts while dw_mmc is suspended (or partly > suspended) seems like a bad idea. We really don't want to be > processing them until we've gotten ourselves fully powered up. > > You might be wondering how it's

[PATCH v2] mmc: dw_mmc: Disable SDIO interrupts while suspended to fix suspend/resume

2019-04-29 Thread Douglas Anderson
Processing SDIO interrupts while dw_mmc is suspended (or partly suspended) seems like a bad idea. We really don't want to be processing them until we've gotten ourselves fully powered up. You might be wondering how it's even possible to become suspended when an SDIO interrupt is active. As can