Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-20 Thread Mathias Krause
On 16 June 2013 04:35, Rusty Russell wrote: > Mathias Krause writes: >> If we pass a pointer to a const string in the form "module:symbol" >> module_kallsyms_lookup_name() will try to split the string at the colon, >> i.e., will try to modify r/o data. That will, in fact, fail on a kernel >>

Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-20 Thread Mathias Krause
On 16 June 2013 04:35, Rusty Russell ru...@rustcorp.com.au wrote: Mathias Krause mini...@googlemail.com writes: If we pass a pointer to a const string in the form module:symbol module_kallsyms_lookup_name() will try to split the string at the colon, i.e., will try to modify r/o data. That

Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-15 Thread Rusty Russell
Mathias Krause writes: > If we pass a pointer to a const string in the form "module:symbol" > module_kallsyms_lookup_name() will try to split the string at the colon, > i.e., will try to modify r/o data. That will, in fact, fail on a kernel > with enabled CONFIG_DEBUG_RODATA. > > Avoid modifying

Re: [PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-15 Thread Rusty Russell
Mathias Krause mini...@googlemail.com writes: If we pass a pointer to a const string in the form module:symbol module_kallsyms_lookup_name() will try to split the string at the colon, i.e., will try to modify r/o data. That will, in fact, fail on a kernel with enabled CONFIG_DEBUG_RODATA.

[PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-14 Thread Mathias Krause
If we pass a pointer to a const string in the form "module:symbol" module_kallsyms_lookup_name() will try to split the string at the colon, i.e., will try to modify r/o data. That will, in fact, fail on a kernel with enabled CONFIG_DEBUG_RODATA. Avoid modifying the passed string in

[PATCH v2] module: don't modify argument of module_kallsyms_lookup_name()

2013-06-14 Thread Mathias Krause
If we pass a pointer to a const string in the form module:symbol module_kallsyms_lookup_name() will try to split the string at the colon, i.e., will try to modify r/o data. That will, in fact, fail on a kernel with enabled CONFIG_DEBUG_RODATA. Avoid modifying the passed string in