Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Ard Biesheuvel
On 26 October 2016 at 14:04, Ard Biesheuvel wrote: > On 26 October 2016 at 11:07, Michael Ellerman wrote: >> Hi Ard, >> >> I like the concept, but ... >> >> Ard Biesheuvel writes: >>> The symbol CRCs are emitted as ELF

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Ard Biesheuvel
On 26 October 2016 at 14:04, Ard Biesheuvel wrote: > On 26 October 2016 at 11:07, Michael Ellerman wrote: >> Hi Ard, >> >> I like the concept, but ... >> >> Ard Biesheuvel writes: >>> The symbol CRCs are emitted as ELF symbols, which allows us to easily >>> populate the kcrctab sections by

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Ard Biesheuvel
On 26 October 2016 at 11:07, Michael Ellerman wrote: > Hi Ard, > > I like the concept, but ... > > Ard Biesheuvel writes: >> The symbol CRCs are emitted as ELF symbols, which allows us to easily >> populate the kcrctab sections by relying on the

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Ard Biesheuvel
On 26 October 2016 at 11:07, Michael Ellerman wrote: > Hi Ard, > > I like the concept, but ... > > Ard Biesheuvel writes: >> The symbol CRCs are emitted as ELF symbols, which allows us to easily >> populate the kcrctab sections by relying on the linker to associate >> each kcrctab slot with the

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Michael Ellerman
Hi Ard, I like the concept, but ... Ard Biesheuvel writes: > The symbol CRCs are emitted as ELF symbols, which allows us to easily > populate the kcrctab sections by relying on the linker to associate > each kcrctab slot with the correct value. > > This has two

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-26 Thread Michael Ellerman
Hi Ard, I like the concept, but ... Ard Biesheuvel writes: > The symbol CRCs are emitted as ELF symbols, which allows us to easily > populate the kcrctab sections by relying on the linker to associate > each kcrctab slot with the correct value. > > This has two downsides: > - given that the

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-25 Thread Rusty Russell
Ard Biesheuvel writes: > The symbol CRCs are emitted as ELF symbols, which allows us to easily > populate the kcrctab sections by relying on the linker to associate > each kcrctab slot with the correct value. > > This has two downsides: > - given that the CRCs are

Re: [PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-25 Thread Rusty Russell
Ard Biesheuvel writes: > The symbol CRCs are emitted as ELF symbols, which allows us to easily > populate the kcrctab sections by relying on the linker to associate > each kcrctab slot with the correct value. > > This has two downsides: > - given that the CRCs are treated as pointers, we waste 4

[PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-20 Thread Ard Biesheuvel
The symbol CRCs are emitted as ELF symbols, which allows us to easily populate the kcrctab sections by relying on the linker to associate each kcrctab slot with the correct value. This has two downsides: - given that the CRCs are treated as pointers, we waste 4 bytes for each CRC on 64 bit

[PATCH v2] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs

2016-10-20 Thread Ard Biesheuvel
The symbol CRCs are emitted as ELF symbols, which allows us to easily populate the kcrctab sections by relying on the linker to associate each kcrctab slot with the correct value. This has two downsides: - given that the CRCs are treated as pointers, we waste 4 bytes for each CRC on 64 bit