Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-04-12 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Thu, 11 Apr 2019 17:20:31 -0500: > On 4/11/19 5:10 PM, Miquel Raynal wrote: > > Hi Gustavo, > > > > "Gustavo A. R. Silva" wrote on Thu, 11 Apr > > 2019 13:30:31 -0500: > > > >> Hi Miquel, > >> > >> On 2/5/19 6:55 AM, Miquel Raynal wrote: > >> [..]

Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-04-11 Thread Gustavo A. R. Silva
On 4/11/19 5:10 PM, Miquel Raynal wrote: > Hi Gustavo, > > "Gustavo A. R. Silva" wrote on Thu, 11 Apr > 2019 13:30:31 -0500: > >> Hi Miquel, >> >> On 2/5/19 6:55 AM, Miquel Raynal wrote: >> [..] @@ -3280,12 +3280,14 @@ static void onenand_check_features(struct mtd_info *mtd)

Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-04-11 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Thu, 11 Apr 2019 13:30:31 -0500: > Hi Miquel, > > On 2/5/19 6:55 AM, Miquel Raynal wrote: > [..] > >> @@ -3280,12 +3280,14 @@ static void onenand_check_features(struct mtd_info > >> *mtd) > >>if ((this->version_id & 0xf) == 0xe) >

Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-04-11 Thread Gustavo A. R. Silva
Hi Miquel, On 2/5/19 6:55 AM, Miquel Raynal wrote: [..] >> @@ -3280,12 +3280,14 @@ static void onenand_check_features(struct mtd_info >> *mtd) >> if ((this->version_id & 0xf) == 0xe) >> this->options |= ONENAND_HAS_NOP_1; >> } >> +

Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-02-08 Thread Gustavo A. R. Silva
Hey Miquel, On 2/5/19 6:55 AM, Miquel Raynal wrote: > Hi Gustavo, > > "Gustavo A. R. Silva" wrote on Mon, 28 Jan > 2019 12:15:20 -0600: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following

Re: [PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-02-05 Thread Miquel Raynal
Hi Gustavo, "Gustavo A. R. Silva" wrote on Mon, 28 Jan 2019 12:15:20 -0600: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mtd/nand/onenand/onenand_base.c:3264:6: warning:

[PATCH v2] mtd: rawnand: mark expected switch fall-throughs

2019-01-28 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/mtd/nand/onenand/onenand_base.c:3264:6: warning: this statement may fall through [-Wimplicit-fallthrough=]