Re:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Liu Xiang
Thanks for your suggestion. Should I send another patch? At 2018-08-28 21:23:05, "Boris Brezillon" wrote: >On Tue, 28 Aug 2018 21:21:16 +0800 >Liu Xiang wrote: > >> If the size of spi-nor flash is larger than 16MB, the read_opcode >> is set to SPINOR_OP_READ_1_1_4_4B, and

Re:Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Liu Xiang
Thanks for your suggestion. Should I send another patch? At 2018-08-28 21:23:05, "Boris Brezillon" wrote: >On Tue, 28 Aug 2018 21:21:16 +0800 >Liu Xiang wrote: > >> If the size of spi-nor flash is larger than 16MB, the read_opcode >> is set to SPINOR_OP_READ_1_1_4_4B, and

Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 22:16:08 +0800 (CST) "Liu Xiang" wrote: > Thanks for your suggestion. Should I send another patch? Yes please.

Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 22:16:08 +0800 (CST) "Liu Xiang" wrote: > Thanks for your suggestion. Should I send another patch? Yes please.

Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 21:21:16 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > > --- > v2: >

Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 21:21:16 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > > --- > v2: >

[PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can cause read operation fail. --- v2: add Fixes tag and CC stable suggested by Boris. --- Fixes:

[PATCH v2] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-28 Thread Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can cause read operation fail. --- v2: add Fixes tag and CC stable suggested by Boris. --- Fixes: