On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris
wrote:
> Hi Viet,
>
> On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
>> From: Viet Nga Dao
>>
>> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
>> EPCS flash chips. This patch adds driver for these devices.
On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris
computersforpe...@gmail.com wrote:
Hi Viet,
On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
From: Viet Nga Dao vn...@altera.com
Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
EPCS flash chips. This
Hi Brian,
Thanks for your detail comment. I will make modification and submit
the separated patches
On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris
wrote:
> Hi Viet,
>
> On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
>> From: Viet Nga Dao
>>
>> Altera EPCQ Controller is a soft IP
Hi Viet,
On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
> From: Viet Nga Dao
>
> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
> EPCS flash chips. This patch adds driver for these devices.
>
> Signed-off-by: VIET NGA DAO
>
> ---
> v2:
> - Change
On Fri, Mar 13, 2015 at 1:45 PM, Rafał Miłecki wrote:
> On 11 March 2015 at 09:41, Viet Nga Dao wrote:
>> On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote:
>>> Ok. I will modify the code the way you suggest.
>>
>> I just realize that the opcode for RDID is handled by hardware in my
>> case,
On Fri, Mar 13, 2015 at 1:45 PM, Rafał Miłecki zaj...@gmail.com wrote:
On 11 March 2015 at 09:41, Viet Nga Dao vn...@altera.com wrote:
On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao vn...@altera.com wrote:
Ok. I will modify the code the way you suggest.
I just realize that the opcode for RDID
Hi Viet,
On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
From: Viet Nga Dao vn...@altera.com
Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
EPCS flash chips. This patch adds driver for these devices.
Signed-off-by: VIET NGA DAO vn...@altera.com
Hi Brian,
Thanks for your detail comment. I will make modification and submit
the separated patches
On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris
computersforpe...@gmail.com wrote:
Hi Viet,
On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote:
From: Viet Nga Dao vn...@altera.com
On 11 March 2015 at 09:41, Viet Nga Dao wrote:
> On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote:
>> Ok. I will modify the code the way you suggest.
>
> I just realize that the opcode for RDID is handled by hardware in my
> case, therefore i dont really need to worry about 0xab opcode.
Nice
Hi,
Could anyone please help me review the lock, unlock modification part
i did in spi-nor?
Thanks,
Viet Nga
On Mon, Feb 23, 2015 at 9:30 AM, Viet Nga Dao wrote:
> Hi,
> It has been nearly 2 weeks since i submitted this patch. Could you
> please help to review?
> Thanks,
>
> On Tue, Feb 17,
On 11 March 2015 at 09:41, Viet Nga Dao vn...@altera.com wrote:
On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao vn...@altera.com wrote:
Ok. I will modify the code the way you suggest.
I just realize that the opcode for RDID is handled by hardware in my
case, therefore i dont really need to
Hi,
Could anyone please help me review the lock, unlock modification part
i did in spi-nor?
Thanks,
Viet Nga
On Mon, Feb 23, 2015 at 9:30 AM, Viet Nga Dao vn...@altera.com wrote:
Hi,
It has been nearly 2 weeks since i submitted this patch. Could you
please help to review?
Thanks,
On Tue,
Hi Rafal,
On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote:
> +
> +/* Altera EPCQ/EPCS Flashes */
> +{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) },
> +{ "epcq32" , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) },
> +{ "epcq64" , EPCQ_INFO(2, 0x17,
Hi Rafal,
On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao vn...@altera.com wrote:
+
+/* Altera EPCQ/EPCS Flashes */
+{ epcq16 , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) },
+{ epcq32 , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) },
+{ epcq64 , EPCQ_INFO(2, 0x17, 0x1, 128,
+
+/* Altera EPCQ/EPCS Flashes */
+{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) },
+{ "epcq32" , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) },
+{ "epcq64" , EPCQ_INFO(2, 0x17, 0x1, 128, 0x100) },
+{ "epcq128" , EPCQ_INFO(2, 0x18,
On 10 March 2015 at 07:11, Viet Nga Dao wrote:
> On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki wrote:
>> On 11 February 2015 at 05:53, Viet Nga Dao wrote:
>>> /* NOTE: double check command sets and memory organization when you add
>>> * more nor chips. This current list focusses on newer
Hi Rafal,
Thanks for your review.
On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki wrote:
> Hi Viet,
>
> I'm not too active in mtd subsystem, so I didn't notice your patch
> earlier. However I would like to share few comments.
>
> On 11 February 2015 at 05:53, Viet Nga Dao wrote:
>> From: Viet Nga
Hi Rafal,
Thanks for your review.
On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki zaj...@gmail.com wrote:
Hi Viet,
I'm not too active in mtd subsystem, so I didn't notice your patch
earlier. However I would like to share few comments.
On 11 February 2015 at 05:53, Viet Nga Dao
On 10 March 2015 at 07:11, Viet Nga Dao vn...@altera.com wrote:
On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki zaj...@gmail.com wrote:
On 11 February 2015 at 05:53, Viet Nga Dao vn...@altera.com wrote:
/* NOTE: double check command sets and memory organization when you add
* more nor chips.
+
+/* Altera EPCQ/EPCS Flashes */
+{ epcq16 , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) },
+{ epcq32 , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) },
+{ epcq64 , EPCQ_INFO(2, 0x17, 0x1, 128, 0x100) },
+{ epcq128 , EPCQ_INFO(2, 0x18, 0x1, 256, 0x100) },
+{
Hi Viet,
I'm not too active in mtd subsystem, so I didn't notice your patch
earlier. However I would like to share few comments.
On 11 February 2015 at 05:53, Viet Nga Dao wrote:
> From: Viet Nga Dao
>
> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
> EPCS flash
Hi Viet,
I'm not too active in mtd subsystem, so I didn't notice your patch
earlier. However I would like to share few comments.
On 11 February 2015 at 05:53, Viet Nga Dao vn...@altera.com wrote:
From: Viet Nga Dao vn...@altera.com
Altera EPCQ Controller is a soft IP which enables access to
Hi Brian,
I understand that you are busy but is it possible if you could spend
some time to help me review my patch? My work progress really depends
on your review.
Thanks,
Viet Nga
On Tue, Feb 24, 2015 at 11:59 AM, Brian Norris
wrote:
> On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao
Hi Brian,
I understand that you are busy but is it possible if you could spend
some time to help me review my patch? My work progress really depends
on your review.
Thanks,
Viet Nga
On Tue, Feb 24, 2015 at 11:59 AM, Brian Norris
computersforpe...@gmail.com wrote:
On Mon, Feb 23, 2015 at
On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao wrote:
> Hi,
> It has been nearly 2 weeks since i submitted this patch. Could you
> please help to review?
Those two weeks were during the merge window, so I wasn't queueing
anything up. And there are things that have waited longer, anyway.
On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga Dao wrote:
Hi,
It has been nearly 2 weeks since i submitted this patch. Could you
please help to review?
Those two weeks were during the merge window, so I wasn't queueing
anything up. And there are things that have waited longer, anyway. My
Hi,
It has been nearly 2 weeks since i submitted this patch. Could you
please help to review?
Thanks,
On Tue, Feb 17, 2015 at 9:33 AM, Viet Nga Dao wrote:
> Hi Brian,
> Could you please help me to review through this 2nd version?
>
> On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote:
>>
Hi,
It has been nearly 2 weeks since i submitted this patch. Could you
please help to review?
Thanks,
On Tue, Feb 17, 2015 at 9:33 AM, Viet Nga Dao vn...@altera.com wrote:
Hi Brian,
Could you please help me to review through this 2nd version?
On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao
Hi Brian,
Could you please help me to review through this 2nd version?
On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote:
> From: Viet Nga Dao
>
> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
> EPCS flash chips. This patch adds driver for these devices.
>
>
Hi Brian,
Could you please help me to review through this 2nd version?
On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao vn...@altera.com wrote:
From: Viet Nga Dao vn...@altera.com
Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
EPCS flash chips. This patch adds
From: Viet Nga Dao
Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
EPCS flash chips. This patch adds driver for these devices.
Signed-off-by: VIET NGA DAO
---
v2:
- Change to spi_nor structure
- Add lock and unlock functions for spi_nor
- Simplify the
From: Viet Nga Dao vn...@altera.com
Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and
EPCS flash chips. This patch adds driver for these devices.
Signed-off-by: VIET NGA DAO vn...@altera.com
---
v2:
- Change to spi_nor structure
- Add lock and unlock functions for
32 matches
Mail list logo
