Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Jakub Kicinski
On Sat, 9 May 2020 22:49:28 +0200 Stephen Kitt wrote: > On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote: > > On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > > > What if we went back to your original proposal of an empty struct but > > > added in an extern in front? That way we

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote: > On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > > What if we went back to your original proposal of an empty struct but > > added in an extern in front? That way we should get linker error on > > pointer references. > > That

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 10:13:22 +0200 Stephen Kitt wrote: > > On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski > > wrote: > > > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > > > Commit c7228317441f ("net: Use a more

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Jakub Kicinski
On Sat, 9 May 2020 10:13:22 +0200 Stephen Kitt wrote: > Hi, > > Thanks for taking the time to review my patch. > > On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski wrote: > > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > > Commit c7228317441f ("net: Use a more standard macro for

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
Hi, Thanks for taking the time to review my patch. On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski wrote: > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > Commit c7228317441f ("net: Use a more standard macro for > > INET_ADDR_COOKIE") added a __deprecated marker to the cookie name

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > Commit c7228317441f ("net: Use a more standard macro for > INET_ADDR_COOKIE") added a __deprecated marker to the cookie name on > 32-bit architectures, with the intent that the compiler would flag > uses of the name. However since commit

[PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Stephen Kitt
Commit c7228317441f ("net: Use a more standard macro for INET_ADDR_COOKIE") added a __deprecated marker to the cookie name on 32-bit architectures, with the intent that the compiler would flag uses of the name. However since commit 771c035372a0 ("deprecate the '__deprecated' attribute warnings