Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Andrew Lunn
> > +/* switch line-side interface between 10GBase-R and 1GBase-X > > + * according to speed */ > > +static void mv_update_interface(struct phy_device *phydev) > > +{ > > + struct mv_data *priv = phydev->priv; > > + > > + if (phydev->speed == SPEED_1 && > > +

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Andrew Lunn
Hi Ivan > +static int sfp_module_insert(void *_priv, const struct sfp_eeprom_id *id) > +{ > + struct phy_device *phydev = _priv; > + struct device *dev = >mdio.dev; > + struct mv_data *priv = phydev->priv; > + phy_interface_t sfp_interface; Reverse Christmas tree please.

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
On Sat, Feb 20, 2021 at 11:53:04AM +, Russell King - ARM Linux admin wrote: > On Sat, Feb 20, 2021 at 12:46:23PM +0300, Ivan Bornyakov wrote: > > + > > + switch (sfp_interface) { > > + case PHY_INTERFACE_MODE_10GBASER: > > + phydev->speed = SPEED_1; > > +

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Russell King - ARM Linux admin
On Sat, Feb 20, 2021 at 12:46:23PM +0300, Ivan Bornyakov wrote: > Add basic support for the Marvell 88X multi-speed ethernet > transceiver. > > This PHY provides data transmission over fiber-optic as well as Twinax > copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X > on

[PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
Add basic support for the Marvell 88X multi-speed ethernet transceiver. This PHY provides data transmission over fiber-optic as well as Twinax copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X on the line-side interface. The host-side interface supports 4 ports of