Re: [PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Peter Wu
On Saturday 21 June 2014 23:00:37 Rickard Strandqvist wrote: > I found a logical error in an if statement that always evaluates to false. > > This has after same discussion resulted in that we add a macro to handle this. The subject is still wrong (it is not a cleanup, but a fix) and the commit

[PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8192ce/hw.c |2 +- drivers/net/wireless/rtlwifi/rtl8192ce/reg.h

[PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): net: wireless: rtlwifi: rtl8192cu:

[PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): net: wireless: rtlwifi: rtl8192cu:

[PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Rickard Strandqvist
I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/net/wireless/rtlwifi/rtl8192ce/hw.c |2 +-

Re: [PATCH v2] net: wireless: rtlwifi: rtl8192cu: hw.c: Cleaning up if statement that always evaluates to false

2014-06-21 Thread Peter Wu
On Saturday 21 June 2014 23:00:37 Rickard Strandqvist wrote: I found a logical error in an if statement that always evaluates to false. This has after same discussion resulted in that we add a macro to handle this. The subject is still wrong (it is not a cleanup, but a fix) and the commit