Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-09-02 Thread Christoph Hellwig
On Mon, Aug 26, 2019 at 01:20:28PM +0200, Marta Rybczynska wrote: > Do you mean something like this? Yes.

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-26 Thread Marta Rybczynska
- On 22 Aug, 2019, at 02:06, Christoph Hellwig h...@lst.de wrote: > On Fri, Aug 16, 2019 at 11:47:21AM +0200, Marta Rybczynska wrote: >> It is not possible to get 64-bit results from the passthru commands, >> what prevents from getting for the Capabilities (CAP) property value. >> >> As a

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-21 Thread Christoph Hellwig
On Fri, Aug 16, 2019 at 11:47:21AM +0200, Marta Rybczynska wrote: > It is not possible to get 64-bit results from the passthru commands, > what prevents from getting for the Capabilities (CAP) property value. > > As a result, it is not possible to implement IOL's NVMe Conformance > test 4.3 Case

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-21 Thread Christoph Hellwig
On Mon, Aug 19, 2019 at 08:49:22AM -0600, Keith Busch wrote: > On Mon, Aug 19, 2019 at 12:06:23AM -0700, Marta Rybczynska wrote: > > - On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: > > > Sorry for not replying to the earlier version, and thanks for doing > > > this work. > >

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Keith Busch
On Mon, Aug 19, 2019 at 02:17:44PM -0700, Sagi Grimberg wrote: > > - On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: > > Sorry for not replying to the earlier version, and thanks for doing > > this work. > > > > I wonder if instead of using our own

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Sagi Grimberg
- On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: Sorry for not replying to the earlier version, and thanks for doing this work. I wonder if instead of using our own structure we'd just use a full nvme SQE for the input and CQE for that output. Even if we reserve a few

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Keith Busch
On Mon, Aug 19, 2019 at 11:56:28AM -0700, Sagi Grimberg wrote: > > >> - On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: > >>> Sorry for not replying to the earlier version, and thanks for doing > >>> this work. > >>> > >>> I wonder if instead of using our own structure we'd

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Sagi Grimberg
- On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: Sorry for not replying to the earlier version, and thanks for doing this work. I wonder if instead of using our own structure we'd just use a full nvme SQE for the input and CQE for that output. Even if we reserve a few

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread James Smart
On 8/19/2019 7:49 AM, Keith Busch wrote: On Mon, Aug 19, 2019 at 12:06:23AM -0700, Marta Rybczynska wrote: - On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: Sorry for not replying to the earlier version, and thanks for doing this work. I wonder if instead of using our

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Keith Busch
On Mon, Aug 19, 2019 at 12:06:23AM -0700, Marta Rybczynska wrote: > - On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: > > Sorry for not replying to the earlier version, and thanks for doing > > this work. > > > > I wonder if instead of using our own structure we'd just use > >

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-19 Thread Marta Rybczynska
- On 16 Aug, 2019, at 15:16, Christoph Hellwig h...@lst.de wrote: > Sorry for not replying to the earlier version, and thanks for doing > this work. > > I wonder if instead of using our own structure we'd just use > a full nvme SQE for the input and CQE for that output. Even if we >

Re: [PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-16 Thread Christoph Hellwig
Sorry for not replying to the earlier version, and thanks for doing this work. I wonder if instead of using our own structure we'd just use a full nvme SQE for the input and CQE for that output. Even if we reserve a few fields that means we are ready for any newly used field (at least until the

[PATCH v2] nvme: allow 64-bit results in passthru commands

2019-08-16 Thread Marta Rybczynska
It is not possible to get 64-bit results from the passthru commands, what prevents from getting for the Capabilities (CAP) property value. As a result, it is not possible to implement IOL's NVMe Conformance test 4.3 Case 1 for Fabrics targets [1] (page 123). This issue has been already discussed