Re: [PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Benjamin Herrenschmidt
On Fri, 2019-07-19 at 05:01 +, Damien Le Moal wrote: > > I suppose that would work and be simpler. I honestly don't know much > > about the block layer and tag allocation so I stayed away from it :-) > > > > I'll dig, but a hint would be welcome :) > > Uuuh.. Never played with the tag

Re: [PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Damien Le Moal
On 2019/07/19 13:49, Benjamin Herrenschmidt wrote: > On Fri, 2019-07-19 at 04:43 +, Damien Le Moal wrote: >> On 2019/07/19 13:37, Benjamin Herrenschmidt wrote: >>> Another issue with the Apple T2 based 2018 controllers seem to be >>> that they blow up (and shut the machine down) if there's a

Re: [PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Benjamin Herrenschmidt
On Fri, 2019-07-19 at 14:49 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2019-07-19 at 04:43 +, Damien Le Moal wrote: > > On 2019/07/19 13:37, Benjamin Herrenschmidt wrote: > > > Another issue with the Apple T2 based 2018 controllers seem to be > > > that they blow up (and shut the machine

Re: [PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Benjamin Herrenschmidt
On Fri, 2019-07-19 at 04:43 +, Damien Le Moal wrote: > On 2019/07/19 13:37, Benjamin Herrenschmidt wrote: > > Another issue with the Apple T2 based 2018 controllers seem to be > > that they blow up (and shut the machine down) if there's a tag > > collision between the IO queue and the Admin

Re: [PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Damien Le Moal
On 2019/07/19 13:37, Benjamin Herrenschmidt wrote: > Another issue with the Apple T2 based 2018 controllers seem to be > that they blow up (and shut the machine down) if there's a tag > collision between the IO queue and the Admin queue. > > My suspicion is that they use our tags for their

[PATCH v2] nvme-pci: Support shared tags across queues for Apple 2018 controllers

2019-07-18 Thread Benjamin Herrenschmidt
Another issue with the Apple T2 based 2018 controllers seem to be that they blow up (and shut the machine down) if there's a tag collision between the IO queue and the Admin queue. My suspicion is that they use our tags for their internal tracking and don't mix them with the queue id. They also