Re: [PATCH v2] objtool: Support multiple rodata sections.

2018-08-28 Thread Josh Poimboeuf
On Fri, Aug 03, 2018 at 07:40:40PM +0100, Allan Xavier wrote: > +static void mark_rodata(struct objtool_file *file) > +{ > + struct section *sec; > + bool found = false; > + static const char *str1 = ".str1."; > + const int str1len = strlen(str1) + 1; > + A comment here would

Re: [PATCH v2] objtool: Support multiple rodata sections.

2018-08-28 Thread Josh Poimboeuf
On Fri, Aug 03, 2018 at 07:40:40PM +0100, Allan Xavier wrote: > +static void mark_rodata(struct objtool_file *file) > +{ > + struct section *sec; > + bool found = false; > + static const char *str1 = ".str1."; > + const int str1len = strlen(str1) + 1; > + A comment here would

Re: [PATCH v2] objtool: Support multiple rodata sections.

2018-08-28 Thread Allan Xavier
Ping... are there any comments on this? On 03/08/18 19:40, Allan Xavier wrote: > This commit adds support for processing switch jump tables in objects > with multiple .rodata sections, such as those created when using > -ffunction-sections and -fdata-sections. Currently, objtool always > looks

Re: [PATCH v2] objtool: Support multiple rodata sections.

2018-08-28 Thread Allan Xavier
Ping... are there any comments on this? On 03/08/18 19:40, Allan Xavier wrote: > This commit adds support for processing switch jump tables in objects > with multiple .rodata sections, such as those created when using > -ffunction-sections and -fdata-sections. Currently, objtool always > looks

[PATCH v2] objtool: Support multiple rodata sections.

2018-08-03 Thread Allan Xavier
This commit adds support for processing switch jump tables in objects with multiple .rodata sections, such as those created when using -ffunction-sections and -fdata-sections. Currently, objtool always looks in .rodata for jump table information which results in many "sibling call from callable

[PATCH v2] objtool: Support multiple rodata sections.

2018-08-03 Thread Allan Xavier
This commit adds support for processing switch jump tables in objects with multiple .rodata sections, such as those created when using -ffunction-sections and -fdata-sections. Currently, objtool always looks in .rodata for jump table information which results in many "sibling call from callable