Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 22:36 +0200, Andy Shevchenko wrote: [] > wondering if _NATIVE is better? I think CPU is better myself and it's already in use like: include/linux/iio/iio.h-enum iio_endian { include/linux/iio/iio.h:IIO_CPU, include/linux/iio/iio.h-IIO_BE,

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 10:17 PM, Rasmus Villemoes wrote: > On Wed, Dec 09 2015, Andy Shevchenko wrote: >> On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: >>> +enum { >>> + DUMP_TYPE_CPU = 0, >> >> And still open this, do we need it? I think you may just mention in >> the documentation

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 09 2015, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: >> --- >> include/linux/printk.h | 7 +++ >> lib/hexdump.c | 39 +++ >> 2 files changed, 38 insertions(+), 8 deletions(-) >> >> diff --git

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 22:02 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: [] > > > > diff --git a/lib/hexdump.c b/lib/hexdump.c > > > > index 992457b..49113aa 100644 > > > > --- a/lib/hexdump.c > > > > +++ b/lib/hexdump.c > > > > @@ -81,6 +81,7 @@

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: > On Wed, 2015-12-09 at 14:03 +0200, Andy Shevchenko wrote: >> On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: >> > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: >> > > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: >> > > > On

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 14:03 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: > > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: > > > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > > > > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > > > >

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: >> On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: >> > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: >> > > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: >> > > >

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: >> On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: >> > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: >> > > On Wed, 2015-12-09 at 01:07

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 14:03 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: > > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: > > > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > > > > On Tue, 2015-12-08 at

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 10:17 PM, Rasmus Villemoes wrote: > On Wed, Dec 09 2015, Andy Shevchenko wrote: >> On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: >>> +enum { >>> + DUMP_TYPE_CPU = 0, >> >> And still open

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 22:02 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: [] > > > > diff --git a/lib/hexdump.c b/lib/hexdump.c > > > > index 992457b..49113aa 100644 > > > > --- a/lib/hexdump.c > > > > +++ b/lib/hexdump.c > > > > @@ -81,6

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 09 2015, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: >> --- >> include/linux/printk.h | 7 +++ >> lib/hexdump.c | 39 +++ >> 2 files changed, 38

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 22:36 +0200, Andy Shevchenko wrote: [] > wondering if _NATIVE is better? I think CPU is better myself and it's already in use like: include/linux/iio/iio.h-enum iio_endian { include/linux/iio/iio.h:IIO_CPU, include/linux/iio/iio.h-IIO_BE,

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches wrote: > On Wed, 2015-12-09 at 14:03 +0200, Andy Shevchenko wrote: >> On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches wrote: >> > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: >> > > On Tue, Dec 8, 2015 at 11:03

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > > > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > > > > Trivial changes suggested by checkpatch.pl. > > > [] > > >

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: >> On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: >> > Trivial changes suggested by checkpatch.pl. >> [] >> > diff --git a/drivers/of/address.c b/drivers/of/address.c >> [] >> >

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > > Trivial changes suggested by checkpatch.pl. > [] > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [] > > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > Trivial changes suggested by checkpatch.pl. [] > diff --git a/drivers/of/address.c b/drivers/of/address.c [] > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev, >  #ifdef DEBUG >  static void

[PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

Trivial changes suggested by checkpatch.pl. Signed-off-by: Masahiro Yamada --- Changes in v2: - Fix printk(KERN_DEBUG ...) too drivers/of/address.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 9582c57..65fafbb

[PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

Trivial changes suggested by checkpatch.pl. Signed-off-by: Masahiro Yamada --- Changes in v2: - Fix printk(KERN_DEBUG ...) too drivers/of/address.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/address.c

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > > Trivial changes suggested by checkpatch.pl. > [] > > diff --git a/drivers/of/address.c b/drivers/of/address.c > [] > > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > Trivial changes suggested by checkpatch.pl. [] > diff --git a/drivers/of/address.c b/drivers/of/address.c [] > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev, >  #ifdef DEBUG >  static void

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote: > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: > > > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > > > > Trivial changes suggested by

Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err()

On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches wrote: > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote: >> On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: >> > Trivial changes suggested by checkpatch.pl. >> [] >> > diff --git a/drivers/of/address.c