Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread David Hildenbrand
> On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: > > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > > add_callchain_ip") promised "No change in behavior.". > > > > As this commit breaks callchains on s390x (symbols not getting resolved, > > I think it's

Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread Jiri Olsa
On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > add_callchain_ip") promised "No change in behavior.". > > As this commit breaks callchains on s390x (symbols not getting resolved, I think it's a generic

[PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread David Hildenbrand
Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to add_callchain_ip") promised "No change in behavior.". As this commit breaks callchains on s390x (symbols not getting resolved, observed when profiling the kernel), this statement is wrong. The cpumode must be kept when iterating

[PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread David Hildenbrand
Commit 2e77784bb7d8 (perf callchain: Move cpumode resolve code to add_callchain_ip) promised No change in behavior.. As this commit breaks callchains on s390x (symbols not getting resolved, observed when profiling the kernel), this statement is wrong. The cpumode must be kept when iterating over

Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread Jiri Olsa
On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: Commit 2e77784bb7d8 (perf callchain: Move cpumode resolve code to add_callchain_ip) promised No change in behavior.. As this commit breaks callchains on s390x (symbols not getting resolved, I think it's a generic problem not

Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode

2015-03-30 Thread David Hildenbrand
On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: Commit 2e77784bb7d8 (perf callchain: Move cpumode resolve code to add_callchain_ip) promised No change in behavior.. As this commit breaks callchains on s390x (symbols not getting resolved, I think it's a generic