Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Pali Rohár
On Monday 19 June 2017 16:39:14 Kai-Heng Feng wrote: > The same rule should also apply to kbd_info.levels, right? IIRC no. levels = 1 means you can set two levels (0 and 1). Look into code. -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Pali Rohár
On Monday 19 June 2017 16:39:14 Kai-Heng Feng wrote: > The same rule should also apply to kbd_info.levels, right? IIRC no. levels = 1 means you can set two levels (0 and 1). Look into code. -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Kai-Heng Feng
On Mon, Jun 19, 2017 at 3:57 PM, Pali Rohár wrote: > On Monday 19 June 2017 15:36:29 Kai-Heng Feng wrote: >> Dell Latitude 3160 does not have keyboard backlight, but there is a >> sysfs interface for it, which does nothing at all. >> >> KBD_LED_ON_TOKEN is the only token can

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Kai-Heng Feng
On Mon, Jun 19, 2017 at 3:57 PM, Pali Rohár wrote: > On Monday 19 June 2017 15:36:29 Kai-Heng Feng wrote: >> Dell Latitude 3160 does not have keyboard backlight, but there is a >> sysfs interface for it, which does nothing at all. >> >> KBD_LED_ON_TOKEN is the only token can be found. Since it

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Pali Rohár
On Monday 19 June 2017 15:36:29 Kai-Heng Feng wrote: > Dell Latitude 3160 does not have keyboard backlight, but there is a > sysfs interface for it, which does nothing at all. > > KBD_LED_ON_TOKEN is the only token can be found. Since it doesn't have *ON* really? > KBD_LED_OFF_TOKEN or

Re: [PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Pali Rohár
On Monday 19 June 2017 15:36:29 Kai-Heng Feng wrote: > Dell Latitude 3160 does not have keyboard backlight, but there is a > sysfs interface for it, which does nothing at all. > > KBD_LED_ON_TOKEN is the only token can be found. Since it doesn't have *ON* really? > KBD_LED_OFF_TOKEN or

[PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Kai-Heng Feng
Dell Latitude 3160 does not have keyboard backlight, but there is a sysfs interface for it, which does nothing at all. KBD_LED_ON_TOKEN is the only token can be found. Since it doesn't have KBD_LED_OFF_TOKEN or KBD_LED_AUTO_*_TOKEN, it should be safe to assume it does not support keyboard

[PATCH v2] platform/x86: dell-laptop: Fix bogus keyboard backlight sysfs interface

2017-06-19 Thread Kai-Heng Feng
Dell Latitude 3160 does not have keyboard backlight, but there is a sysfs interface for it, which does nothing at all. KBD_LED_ON_TOKEN is the only token can be found. Since it doesn't have KBD_LED_OFF_TOKEN or KBD_LED_AUTO_*_TOKEN, it should be safe to assume it does not support keyboard