Re: [PATCH v2] platform/x86: wmi: fix potential null pointer dereference

2019-02-20 Thread Darren Hart
On Wed, Jan 30, 2019 at 05:43:34PM +0200, Andy Shevchenko wrote: > On Wed, Jan 30, 2019 at 5:15 PM Mattias Jacobsson <2...@mok.nu> wrote: > > > > In the function wmi_dev_match() the variable id is dereferenced without > > first performing a NULL check. The variable can for example be NULL if > > a

Re: [PATCH v2] platform/x86: wmi: fix potential null pointer dereference

2019-01-30 Thread Andy Shevchenko
On Wed, Jan 30, 2019 at 5:15 PM Mattias Jacobsson <2...@mok.nu> wrote: > > In the function wmi_dev_match() the variable id is dereferenced without > first performing a NULL check. The variable can for example be NULL if > a WMI driver is registered without specifying the id_table field in > struct

[PATCH v2] platform/x86: wmi: fix potential null pointer dereference

2019-01-30 Thread Mattias Jacobsson
In the function wmi_dev_match() the variable id is dereferenced without first performing a NULL check. The variable can for example be NULL if a WMI driver is registered without specifying the id_table field in struct wmi_driver. Add a NULL check and return that the driver can't handle the device