Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:34 PM, Matthew Garrett wrote: > On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett wrote: >> > The easiest is to just do it from userspace. I think Intel have some >> > code for doing this, but I haven't

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: > On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett wrote: > > The easiest is to just do it from userspace. I think Intel have some > > code for doing this, but I haven't looked at the thermal code for years. > > That defeats the

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett wrote: > On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett >> wrote: >> > It wouldn't be appropriate to alter the firmware behaviour by default, >> > but yeah, that's the kind

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: > On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett wrote: > > It wouldn't be appropriate to alter the firmware behaviour by default, > > but yeah, that's the kind of thing that the thermal framework exists to > > do. > > Well,

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett wrote: > On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: >> On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett >> wrote: >> > The spec doesn't seem to constrain it to physical addresses (it just >> > refers to "Control Methods

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: > On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett wrote: > > The spec doesn't seem to constrain it to physical addresses (it just > > refers to "Control Methods read and write data to locations in address > > spaces (for example,

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett mj...@srcf.ucam.org wrote: The spec doesn't seem to constrain it to physical addresses (it just refers to Control Methods read and write data to locations in address spaces

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 13, 2013 at 09:31:25PM -0500, Felipe Contreras wrote: On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett mj...@srcf.ucam.org wrote: The spec doesn't seem to constrain it to physical addresses (it just

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett mj...@srcf.ucam.org wrote: It wouldn't be appropriate to alter the firmware behaviour by default, but yeah, that's the kind of thing that the thermal framework exists to do.

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett mj...@srcf.ucam.org wrote: It wouldn't be appropriate to alter the firmware behaviour by default,

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Matthew Garrett
On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett mj...@srcf.ucam.org wrote: The easiest is to just do it from userspace. I think Intel have some code for doing this, but I haven't looked at the thermal code for years. That

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-14 Thread Felipe Contreras
On Mon, Oct 14, 2013 at 6:34 PM, Matthew Garrett mj...@srcf.ucam.org wrote: On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett mj...@srcf.ucam.org wrote: The easiest is to just do it from userspace. I think Intel have some code

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett wrote: > On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: > >> I don't see anything in acpi_ex_system_memory_space_handler() that >> takes into consideration virtual addresses. > > The spec doesn't seem to constrain it to physical

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: > I don't see anything in acpi_ex_system_memory_space_handler() that > takes into consideration virtual addresses. The spec doesn't seem to constrain it to physical addresses (it just refers to "Control Methods read and write

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 11:06 AM, Matthew Garrett wrote: > On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote: > >> >> This doesn't really seems to be related to wmi, and is likely to be >> available only on a subset of models. Maybe it should a separate >> driver instead ? > > This version

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 10:59 AM, Corentin Chary wrote: > > > > On Tue, Oct 8, 2013 at 1:48 PM, Felipe Contreras > wrote: >> >> Simple driver to enable control of the fan in ASUS laptops. So far this >> has only been tested in ASUS Zenbook Prime UX31A, but according to some >> online reference

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 10:59 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Tue, Oct 8, 2013 at 1:48 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Thu, Oct 10, 2013 at 11:06 AM, Matthew Garrett matthew.garr...@nebula.com wrote: On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote: This doesn't really seems to be related to wmi, and is likely to be available only on a subset of models. Maybe it should a separate driver instead ?

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Matthew Garrett
On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. The spec doesn't seem to constrain it to physical addresses (it just refers to Control Methods read and write data

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-13 Thread Felipe Contreras
On Sun, Oct 13, 2013 at 10:17 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Sun, Oct 13, 2013 at 04:29:34AM -0500, Felipe Contreras wrote: I don't see anything in acpi_ex_system_memory_space_handler() that takes into consideration virtual addresses. The spec doesn't seem to constrain it

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-10 Thread Matthew Garrett
On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote: > > This doesn't really seems to be related to wmi, and is likely to be > available only on a subset of models. Maybe it should a separate > driver instead ? This version seems to be implemented entirely in WMI, and it's using the same

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-10 Thread Matthew Garrett
On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote: This doesn't really seems to be related to wmi, and is likely to be available only on a subset of models. Maybe it should a separate driver instead ? This version seems to be implemented entirely in WMI, and it's using the same WMI

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
On Tue, Oct 8, 2013 at 7:48 AM, Felipe Contreras wrote: > Simple driver to enable control of the fan in ASUS laptops. So far this > has only been tested in ASUS Zenbook Prime UX31A, but according to some > online reference [1], it should work in other models as well. > > The implementation is

[PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some online reference [1], it should work in other models as well. The implementation is very straight-forward, the only caveat is that the fan speed needs to

[PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some online reference [1], it should work in other models as well. The implementation is very straight-forward, the only caveat is that the fan speed needs to

Re: [PATCH v2] platform: x86: asus-wmi: add fan control

2013-10-08 Thread Felipe Contreras
On Tue, Oct 8, 2013 at 7:48 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Simple driver to enable control of the fan in ASUS laptops. So far this has only been tested in ASUS Zenbook Prime UX31A, but according to some online reference [1], it should work in other models as well. The