Re: [PATCH v2] printk: Userspace format enumeration support

2021-02-09 Thread Chris Down
Greg Kroah-Hartman writes: How can file ever be NULL? And if it is an error, what is the problem here? You can always feed the output of a debugfs_* call back into debugfs, and you never need to check the return values. Oh, thanks -- that's helpful to know. Looks like I misread debugfs_creat

Re: [PATCH v2] printk: Userspace format enumeration support

2021-02-08 Thread Greg Kroah-Hartman
On Tue, Feb 09, 2021 at 04:37:19AM +, Chris Down wrote: > + > + file = debugfs_create_file(ps_get_module_name(ps), 0444, dfs_formats, > +mod, &dfs_formats_fops); > + > + if (IS_ERR_OR_NULL(file)) How can file ever be NULL? And if it is an error, what is

[PATCH v2] printk: Userspace format enumeration support

2021-02-08 Thread Chris Down
We have a number of systems industry-wide that have a subset of their functionality that works as follows: 1. Receive a message from local kmsg, serial console, or netconsole; 2. Apply a set of rules to classify the message; 3. Do something based on this classification (like scheduling a remedi